Conversation
Signed-off-by: Martin Gencur <mgencur@redhat.com>
|
@mgencur: This pull request references Jira Issue OCPBUGS-123170, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe Hypershift KubeVirt CSI E2E workflow now sets ChangesCSI E2E Workflow
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The workflow change is limited to configuring the documented Red Hat operator subscription source and is ready to merge. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/jira refresh |
|
@mgencur: This pull request references Jira Issue OCPBUGS-123170, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mgencur: This pull request references Jira Issue OCPBUGS-123170, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mgencur, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-kubevirt-aws-ovn-csi |
|
@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jparrill, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mgencur: This pull request references Jira Issue OCPBUGS-123170, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. This pull request references CNTRLPLANE-4351 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mgencur: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://redhat.atlassian.net/browse/OCPBUGS-123170
https://redhat.atlassian.net/browse/CNTRLPLANE-4351
This is similar to #84848
This approach is already used in e2e-azure-kubevirt-ovn test for "release-5.1" branch which successfully passes the KubeVirt installation phase, and also uses ODF.
We need to keep ODF in the installation path because without ODF, HyperShift will use the management cluster’s default StorageClass, normally gp3-csi. Standard CSI tests may work, but this workflow also runs the RWX tests, which require ReadWriteMany; AWS gp3-csi is not suitable for that.
Summary by CodeRabbit
The HyperShift KubeVirt CSI end-to-end workflow now installs KubeVirt components from Red Hat operators by setting
CNV_SUBSCRIPTION_SOURCE=redhat-operators. It retains ODF installation to support the workflow’s RWX CSI tests.