Skip to content

OCPBUGS-123170,CNTRLPLANE-4351: ci(hypershift): use Red Hat operators for KubeVirt CSI - #85089

Open
mgencur wants to merge 1 commit into
openshift:mainfrom
mgencur:kubevirt_csi_cnv
Open

mgencur wants to merge 1 commit into
openshift:mainfrom
mgencur:kubevirt_csi_cnv

Conversation

@mgencur

@mgencur mgencur commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

https://redhat.atlassian.net/browse/OCPBUGS-123170
https://redhat.atlassian.net/browse/CNTRLPLANE-4351

This is similar to #84848
This approach is already used in e2e-azure-kubevirt-ovn test for "release-5.1" branch which successfully passes the KubeVirt installation phase, and also uses ODF.
We need to keep ODF in the installation path because without ODF, HyperShift will use the management cluster’s default StorageClass, normally gp3-csi. Standard CSI tests may work, but this workflow also runs the RWX tests, which require ReadWriteMany; AWS gp3-csi is not suitable for that.

Summary by CodeRabbit

The HyperShift KubeVirt CSI end-to-end workflow now installs KubeVirt components from Red Hat operators by setting CNV_SUBSCRIPTION_SOURCE=redhat-operators. It retains ODF installation to support the workflow’s RWX CSI tests.

Signed-off-by: Martin Gencur <mgencur@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 14, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@mgencur: This pull request references Jira Issue OCPBUGS-123170, which is invalid:

  • expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-123170

This is similar to #84848
This approach is already used in e2e-azure-kubevirt-ovn test for "release-5.1" branch which successfully passes the KubeVirt installation phase, and also uses ODF.
We need to keep ODF in the installation path because without ODF, HyperShift will use the management cluster’s default StorageClass, normally gp3-csi. Standard CSI tests may work, but this workflow also runs the RWX tests, which require ReadWriteMany; AWS gp3-csi is not suitable for that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1150783f-b359-4388-a87c-5b7693218559

📥 Commits

Reviewing files that changed from the base of the PR and between 5b094fa and d2349e6.

📒 Files selected for processing (1)
  • ci-operator/step-registry/hypershift/kubevirt/csi-e2e/hypershift-kubevirt-csi-e2e-workflow.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The Hypershift KubeVirt CSI E2E workflow now sets CNV_SUBSCRIPTION_SOURCE to redhat-operators.

Changes

CSI E2E Workflow

Layer / File(s) Summary
Subscription source configuration
ci-operator/step-registry/hypershift/kubevirt/csi-e2e/hypershift-kubevirt-csi-e2e-workflow.yaml
Adds CNV_SUBSCRIPTION_SOURCE=redhat-operators to the workflow environment.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to d2349

The workflow change is limited to configuring the documented Red Hat operator subscription source and is ready to merge.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes only the workflow environment by adding CNV_SUBSCRIPTION_SOURCE: redhat-operators. The exact diff contains no Ginkgo test declarations or test-title formatting, so it introd…
Test Structure And Quality ✅ Passed PASS: The pull request changes only one workflow YAML file by adding CNV_SUBSCRIPTION_SOURCE: redhat-operators. The authoritative diff contains no Ginkgo It blocks or test code. Therefore the list…
Microshift Test Compatibility ✅ Passed The pull request changes only one workflow YAML file. It adds CNV_SUBSCRIPTION_SOURCE: redhat-operators and adds no new Ginkgo tests or test bodies. Therefore, the MicroShift test compatibility chec…
Single Node Openshift (Sno) Test Compatibility ✅ Passed The review-scoped diff changes only hypershift-kubevirt-csi-e2e-workflow.yaml. It adds the CNV_SUBSCRIPTION_SOURCE environment variable and does not add or modify any Ginkgo e2e test. Therefore, t…
Topology-Aware Scheduling Compatibility ✅ Passed PASS — The reviewed range changes only CNV_SUBSCRIPTION_SOURCE in the workflow environment. The variable selects the KubeVirt subscription catalog source; it does not add or modify deployment manife…
Ote Binary Stdout Contract ✅ Passed The pull request changes only one workflow YAML file. It adds the CNV_SUBSCRIPTION_SOURCE environment variable and changes no OTE binary, Go process-level code, suite setup, logging, or stdout behav…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS. The pull request changes one workflow YAML file and adds only the CNV_SUBSCRIPTION_SOURCE: redhat-operators environment variable. The reviewed range adds no Ginkgo tests or test code, so the I…
No-Weak-Crypto ✅ Passed The pull request changes only one workflow environment value: CNV_SUBSCRIPTION_SOURCE: redhat-operators. The authoritative diff contains no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, o…
Container-Privileges ✅ Passed The pull request changes one workflow environment variable: CNV_SUBSCRIPTION_SOURCE: redhat-operators. The exact patch adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, `allowP…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The pull request adds only the public value CNV_SUBSCRIPTION_SOURCE: redhat-operators to a workflow environment. The referenced installer may echo this catalog-source name, but it is not a pas…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the HyperShift KubeVirt CSI change and states that the workflow will use Red Hat operators.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@mgencur

mgencur commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 14, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@mgencur: This pull request references Jira Issue OCPBUGS-123170, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2026
@openshift-ci
openshift-ci Bot requested review from nunnatsa and orenc1 September 14, 2026 09:46
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@mgencur: This pull request references Jira Issue OCPBUGS-123170, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-123170

This is similar to #84848
This approach is already used in e2e-azure-kubevirt-ovn test for "release-5.1" branch which successfully passes the KubeVirt installation phase, and also uses ODF.
We need to keep ODF in the installation path because without ODF, HyperShift will use the management cluster’s default StorageClass, normally gp3-csi. Standard CSI tests may work, but this workflow also runs the RWX tests, which require ReadWriteMany; AWS gp3-csi is not suitable for that.

Summary by CodeRabbit

The HyperShift KubeVirt CSI end-to-end workflow now installs KubeVirt components from Red Hat operators by setting CNV_SUBSCRIPTION_SOURCE=redhat-operators. It retains ODF installation to support the workflow’s RWX CSI tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@mgencur, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't checkout base SHA 066482be7fbefa7be5671261b43c038524210ad7: error checking out "066482be7fbefa7be5671261b43c038524210ad7": exit status 128 fatal: unable to read tree (066482be7fbefa7be5671261b43c038524210ad7)

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mgencur

mgencur commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-kubevirt-aws-ovn-csi

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jparrill jparrill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Ohh it was approved already...

@jparrill

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2026
@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur mgencur changed the title OCPBUGS-123170: ci(hypershift): use Red Hat operators for KubeVirt CSI OCPBUGS-123170,CNTRLPLANE-4351: ci(hypershift): use Red Hat operators for KubeVirt CSI Sep 14, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@mgencur: This pull request references Jira Issue OCPBUGS-123170, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references CNTRLPLANE-4351 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-123170
https://redhat.atlassian.net/browse/CNTRLPLANE-4351

This is similar to #84848
This approach is already used in e2e-azure-kubevirt-ovn test for "release-5.1" branch which successfully passes the KubeVirt installation phase, and also uses ODF.
We need to keep ODF in the installation path because without ODF, HyperShift will use the management cluster’s default StorageClass, normally gp3-csi. Standard CSI tests may work, but this workflow also runs the RWX tests, which require ReadWriteMany; AWS gp3-csi is not suitable for that.

Summary by CodeRabbit

The HyperShift KubeVirt CSI end-to-end workflow now installs KubeVirt components from Red Hat operators by setting CNV_SUBSCRIPTION_SOURCE=redhat-operators. It retains ODF installation to support the workflow’s RWX CSI tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@mgencur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-kubevirt-aws-ovn-csi d2349e6 link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-kubevirt-aws-ovn-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants