CNTRLPLANE-3423: feat: inject centralized TLS into console operand

[ingvagabund]

Operator part implemented in openshift/console-operator#1167.

This covers the operand side as well.

Summary by CodeRabbit

• New Features

  • Added support for configuring the minimum TLS version and permitted cipher suites for HTTP(S) serving.
  • Applied the configured TLS settings to incoming secure connections.

• Bug Fixes

  • Fixed serving configuration so supported TLS options (minTLSVersion, cipherSuites) are no longer incorrectly treated as unsupported fields.
  • Invalid TLS version or cipher suite values now return clear errors instead of proceeding with misconfiguration.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@ingvagabund: This pull request references CNTRLPLANE-3423 which is a valid jira issue.

Details

In response to this:

Operator part implemented in openshift/console-operator#1167.

This covers the operand side as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c5da6844-d09f-4995-9c0d-ebb78c39ed80

📥 Commits

Reviewing files that changed from the base of the PR and between 2b94ecf and a99bf5e.

⛔ Files ignored due to path filters (11)

• go.sum is excluded by !**/*.sum
• vendor/github.com/openshift/client-go/oauth/applyconfigurations/internal/internal.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/client-go/oauth/applyconfigurations/oauth/v1/clusterrolescoperestriction.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/client-go/oauth/applyconfigurations/oauth/v1/oauthaccesstoken.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/client-go/oauth/applyconfigurations/oauth/v1/oauthauthorizetoken.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/client-go/oauth/applyconfigurations/oauth/v1/oauthclient.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/client-go/oauth/applyconfigurations/oauth/v1/oauthclientauthorization.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/client-go/oauth/applyconfigurations/oauth/v1/scoperestriction.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/client-go/oauth/applyconfigurations/oauth/v1/useroauthaccesstoken.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/library-go/pkg/crypto/crypto.go is excluded by !**/vendor/**, !vendor/**
• vendor/modules.txt is excluded by !**/vendor/**, !vendor/**

📒 Files selected for processing (4)

• cmd/bridge/main.go
• go.mod
• pkg/serverconfig/config.go
• pkg/serverconfig/types.go

💤 Files with no reviewable changes (1)

• pkg/serverconfig/config.go

🚧 Files skipped from review as they are similar to previous changes (3)

• cmd/bridge/main.go
• pkg/serverconfig/types.go
• go.mod

---

Walkthrough

Serving configuration now accepts minimum TLS version and cipher suite settings. The bridge passes these values to the listener, which validates and applies them to tls.Config. OpenShift module revisions were also updated.

Changes

TLS serving configuration

Layer / File(s)	Summary
Serving configuration contract pkg/serverconfig/types.go, pkg/serverconfig/config.go, go.mod	TLS fields are accepted outside the unsupported console fields, and OpenShift module revisions are updated.
Listener TLS application cmd/bridge/main.go	main passes TLS settings to listen; valid values configure tls.Config, while invalid values return errors.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: jhadvig, leo6leo

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is far too brief and omits the required analysis, solution, testing, screenshots, and reviewer sections.	Expand the description to fill the template sections, especially root cause, solution details, test setup/cases, and reviewer info.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: injecting centralized TLS into the console operand.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No test files changed in the PR diff, and no Ginkgo titles with dynamic content were introduced.
Test Structure And Quality	✅ Passed	No Ginkgo test files or assertions were added/modified in the touched code, so this quality check is not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo/e2e test files or It/Describe/Context additions appear in the diff; only library/config changes, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new or modified Ginkgo/e2e tests are present; the diff is dependency/vendor-only, so there are no SNO assumptions to flag.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The PR only adds TLS serving/config parsing; I found no deployment/controller changes or scheduling constraints (affinity, nodeSelector, PDB, spread).
Ote Binary Stdout Contract	✅ Passed	Touched process-level code only logs/errors to klog or stderr; no stdout-printing APIs were added, and klog defaults to stderr.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo/e2e tests were added; the PR only changes config, vendored code, and dependency versions, so no IPv4 or external-connectivity test assumptions are introduced.
No-Weak-Crypto	✅ Passed	The patch only wires validated TLS settings and updates defaults to strong AEAD suites; no new weak algorithms or secret comparisons were introduced.
Container-Privileges	✅ Passed	Changed code only updates TLS serving config and flag parsing; no privileged, hostNetwork/IPC/PID, allowPrivilegeEscalation, or securityContext settings were added.
No-Sensitive-Data-In-Logs	✅ Passed	PR diff only bumps deps; no new log statements or sensitive-data exposure was added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)

go.mod

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

go.mod (1)

18-19: 🔒 Security & Privacy | 🔵 Trivial

Verify dependency integrity and supply-chain checks.

These are exact pseudo-versions, but verify matching go.sum entries, OSV/govulncheck results, and the existing SBOM, provenance, and signing checks before merging. As per path instructions, dependency updates must be pin-checked, CVE-checked with OSV, and covered by provenance/signing controls.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` around lines 18 - 19, Verify the pinned openshift/client-go and
openshift/library-go pseudo-versions against matching go.sum entries, then run
the required OSV/govulncheck vulnerability checks and confirm the existing SBOM,
provenance, signing, and pin-validation controls cover both dependencies before
merging.

Source: Path instructions

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@cmd/bridge/main.go`:
- Around line 834-843: Update the cipher-suite validation in the loop that calls
oscrypto.CipherSuite before assigning tlsConfig.CipherSuites to reject TLS
1.3-only cipher names, and reject any mixed list containing unsupported TLS 1.3
values. Preserve acceptance of cipher suites applicable to TLS 1.0–1.2 and
return a clear validation error identifying the unsupported name.

---

Nitpick comments:
In `@go.mod`:
- Around line 18-19: Verify the pinned openshift/client-go and
openshift/library-go pseudo-versions against matching go.sum entries, then run
the required OSV/govulncheck vulnerability checks and confirm the existing SBOM,
provenance, signing, and pin-validation controls cover both dependencies before
merging.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 839cc409-0815-4e80-b4d2-9abea68b6822

📥 Commits

Reviewing files that changed from the base of the PR and between 56550c1 and 2b94ecf.

⛔ Files ignored due to path filters (11)

• go.sum is excluded by !**/*.sum
• vendor/github.com/openshift/client-go/oauth/applyconfigurations/internal/internal.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/client-go/oauth/applyconfigurations/oauth/v1/clusterrolescoperestriction.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/client-go/oauth/applyconfigurations/oauth/v1/oauthaccesstoken.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/client-go/oauth/applyconfigurations/oauth/v1/oauthauthorizetoken.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/client-go/oauth/applyconfigurations/oauth/v1/oauthclient.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/client-go/oauth/applyconfigurations/oauth/v1/oauthclientauthorization.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/client-go/oauth/applyconfigurations/oauth/v1/scoperestriction.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/client-go/oauth/applyconfigurations/oauth/v1/useroauthaccesstoken.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/library-go/pkg/crypto/crypto.go is excluded by !**/vendor/**, !vendor/**
• vendor/modules.txt is excluded by !**/vendor/**, !vendor/**

📒 Files selected for processing (4)

• cmd/bridge/main.go
• go.mod
• pkg/serverconfig/config.go
• pkg/serverconfig/types.go

💤 Files with no reviewable changes (1)

• pkg/serverconfig/config.go

[jhadvig]

/lgtm
/approve

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console
/test e2e-playwright

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ingvagabund]

/verified locally
The tls injection will not get injected until openshift/console-operator#1196 is merged as well.

[openshift-ci-robot]

@ingvagabund: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified locally
The tls injection will not get injected until openshift/console-operator#1196 is merged as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ingvagabund]

/retest-required

[ingvagabund]

/label docs-approved

[ingvagabund]

/label px-approved

[ingvagabund]

/verified by @ingvagabund

[openshift-ci-robot]

@ingvagabund: This PR has been marked as verified by @ingvagabund.

Details

In response to this:

/verified by @ingvagabund

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@ingvagabund: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-playwright	a99bf5e	link	false	/test e2e-playwright

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.