OCPBUGS-88416 OCPBUGS-88398: Bump Axios to fix CVE-2026-44486. Requires a Patch of axios 0.33.0 types to be compatible with old version of TS - #16793
Conversation
…axios 0.33.0 types to be compatible with older version of TypeScript
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@rhdmalone: This pull request references Jira Issue OCPBUGS-88416, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/retitle OCPBUGS-88416 OCPBUGS-88398: Bump Axios to fix CVE-2026-44486. Requires a Patch of axios 0.33.0 types to be compatible with old version of TS |
|
@rhdmalone: This pull request references Jira Issue OCPBUGS-88416, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-88398, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@rhdmalone: This pull request references Jira Issue OCPBUGS-88416, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-88398, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label backport-risk-assessed |
|
/jira refresh |
|
@rhdmalone: This pull request references Jira Issue OCPBUGS-88416, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request. This pull request references Jira Issue OCPBUGS-88398, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by CI |
|
@rhdmalone: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
this has been already approved: /lgtm |
|
Scheduling required tests: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: germanparente, logonoff, rhdmalone The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-gcp-console |
1 similar comment
|
/test e2e-gcp-console |
|
/test e2e-gcp-console |
1 similar comment
|
/test e2e-gcp-console |
|
analysis of failing test e2e-gcp-console by Sustaining Agentic Bot: |
|
/test e2e-gcp-console |
1 similar comment
|
/test e2e-gcp-console |
|
@germanparente I asked the sustaining agentic bot to analyse the last failure for e2e-gcp-console: GCP compute resource exhaustion in zone us-central1-f caused the cluster installation to fail — the e2-custom-6-16384 VM instance type was unavailable in that zone at the time of the run. Recommendation |
|
since the test is failing and it's not related to this PR: /override ci/prow/e2e-gcp-console |
|
@germanparente: Overrode contexts on behalf of germanparente: ci/prow/e2e-gcp-console DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@rhdmalone: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1271391
into
openshift:release-4.12
|
@rhdmalone: Jira Issue Verification Checks: Jira Issue OCPBUGS-88416 Jira Issue OCPBUGS-88416 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 Jira Issue Verification Checks: Jira Issue OCPBUGS-88398 Jira Issue OCPBUGS-88398 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in release 4.12.0-0.nightly-2026-08-11-003124 |
OCPBUGS-88416: Bump Axios to fix CVE-2026-44486. Requires a Patch of axios 0.33.0 types to be compatible with an older version of TypeScript
Fixes CVE-2026-44486.
https://redhat.atlassian.net/browse/OCPBUGS-88416
How this patch was generated:
Step 1:
From frontend/:
Point deps at unpatched 0.33.0 temporarily i.e. In frontend/package.json:
Dependency:
"axios": "0.33.0"
Step 2:
cd frontend
yarn install
yarn patch axios@npm:0.33.0
Yarn prints a temp folder path.
For example:
yarn patch axios@npm:0.33.0
➤ YN0000: Package axios@npm:0.33.0 got extracted with success!
➤ YN0000: You can now edit the following folder: /private/var/folders/xh/64_dr2_j14s6q3vdq008bj9r0000gn/T/xfs-9ac099cb/user
➤ YN0000: Once you are done run yarn patch-commit -s /private/var/folders/xh/64_dr2_j14s6q3vdq008bj9r0000gn/T/xfs-9ac099cb/user and Yarn will store a patchfile based on your changes.
➤ YN0000: Done in 0s 23ms
Apply the same TypeScript fix in that folder’s index.d.ts
For example:
get the directory that is listed e.g./private/var/folders/xh/64_dr2_j14s6q3vdq008bj9r0000gn/T/xfs-8bb6f632/user
in that folder, edit and save the file index.d.ts
replace
type MethodsHeaders = {
[Key in Method as Lowercase]: AxiosHeaders;
};
with
type LowercaseMethod =
| 'get' | 'delete' | 'head' | 'options' | 'post'
| 'put' | 'patch' | 'purge' | 'link' | 'unlink';
type MethodsHeaders = {
[Key in LowercaseMethod]?: AxiosHeaders;
};
Step 3:
Apply changes:
yarn patch-commit -s /private/var/folders/xh/64_dr2_j14s6q3vdq008bj9r0000gn/T/xfs-9ac099cb/user
yarn install
yarn build
Step 4:
Add and commit changes etc
to determine the name of the patch, find it in the folder .yarn/patches - it will start with the name axios-npm-0.33.0
git add .yarn/patches/axios-npm-0.33.0-023deda7e4.patch
git add package.json
git add yarn.lock
git commit -m "OCPBUGS-88416: Bump Axios to fix CVE-2026-44486. Requires a Patch of axios 0.33.0 types to be compatible with older version of TypeScript"
git push
Testing
in the main console folder,
Test 1
./build-frontend.sh > test-4.12.axios-bump.txt
The output file was anlaysed by Claude:
Verdict: PASS — ./build-frontend.sh succeeded on release-4.12-260721 with the axios 0.33.0 Yarn type patch.
Test 2
./build-demos.sh > test-4.12-build-demos.txt
The output file was anlaysed by Claude:
Verdict: PASS - webpack 5.73.0 compiled successfully in 5628 ms