[release-4.13] OCPBUGS-88410 OCPBUGS-88442: CVE-2026-44486 openshift4/ose-console: Axios: Information disclosure of proxy credentials via HTTP redirects#16779
Conversation
…Axios: Information disclosure of proxy credentials via HTTP redirects
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@rhdmalone: This pull request references Jira Issue OCPBUGS-88410, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rhdmalone The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Comment on failing backend test from Claude: Root cause Starting ChartMuseum {"host": "0.0.0.0", "port": 9181} Relation to PR #16779 Next step /test backend` |
|
/test backend |
1 similar comment
|
/test backend |
|
backend test has failed again |
|
/test backend |
4 similar comments
|
/test backend |
|
/test backend |
|
/test backend |
|
/test backend |
|
@rhdmalone: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by CI |
|
@rhdmalone: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rhdmalone: This pull request references Jira Issue OCPBUGS-88410, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-88442, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
OCPBUGS-88410 requires an Axios bump to >= 0.32.0
Previously, a bump of Axios to 0.31.1 had been done using that patch is not sufficient
Therefore, the patch has been updated as below using information from Claude.
NB: Note that the best way to view the new patch is to view the file in its entirety:
https://github.com/rhdmalone/console/blob/831fbc5425326b2dfa7e8c37ee30701744bc6279/frontend/.yarn/patches/axios-npm-0.33.0-023deda7e4.patch
On release-4.13 you still need the TypeScript patch: the branch uses TypeScript 3.8.3, and axios 0.33.0 still uses Lowercase<> / key remapping (as) in MethodsHeaders, which need TS 4.1+. So bump the package and re-create the Yarn patch against 0.33.0.
Recommended (Yarn 4) flow
From frontend/:
In frontend/package.json:
Dependency:
"axios": "0.33.0"
Resolution (replace the patched 0.31.1 line):
"axios@npm:^0.21.1": "0.33.0"
Install and create a patch workspace:
cd frontend
yarn install
yarn patch axios@npm:0.33.0
Yarn prints a temp folder path.
Apply the same TypeScript fix in that folder’s index.d.ts
Replace:
type MethodsHeaders = {
[Key in Method as Lowercase]: AxiosHeaders;
};
with (same as your current patch):
type LowercaseMethod =
| 'get' | 'delete' | 'head' | 'options' | 'post'
| 'put' | 'patch' | 'purge' | 'link' | 'unlink';
type MethodsHeaders = {
[Key in LowercaseMethod]?: AxiosHeaders;
};
4. Commit the patch
yarn patch-commit -s
That writes a new file under frontend/.yarn/patches/ (e.g. axios-npm-0.33.0-….patch) and updates package.json to use patch:axios@npm%3A0.33.0#~/.yarn/patches/....
Set:
"axios@npm:^0.21.1": "patch:axios@npm%3A0.33.0#~/.yarn/patches/"
(use the exact string Yarn put on the "axios" dependency)
Then:
yarn install
6. Cleanup
Remove the old patch:
frontend/.yarn/patches/axios-npm-0.31.1-0574a0de7d.patch
Confirm yarn.lock shows axios@patch:…0.33.0… and version 0.33.0
Spot-check TypeScript/build (yarn lint/tsc or your usual console build)
What not to do
Don’t only edit package.json to 0.33.0 without regenerating the patch: the old 0.31.1 patch path won’t apply cleanly, and unpatched 0.33.0 will break under TS 3.8.3.