Conversation
danoli3
changed the title
…tings Follow-up to ae054c2 which introduced the typo.
Cherry-picked from Jonathhhan/Emscripten-glInfoExample-fix - Wrap GL limits and file handling in #ifndef TARGET_EMSCRIPTEN - Original PR: openframeworks#7211
Cherry-picked from Jonathhhan/Emscripten_audioDeviceSelect_draft - Add library_audioDeviceSelect.js for audio device enumeration - Update library_html5audio.js - Add --post-js for audioDeviceSelect in config.emscripten.default.mk - Original PR: openframeworks#7261
Cherry-picked from Jonathhhan/Emscripten_recordVideo - Add recordVideo.js and fix-webm-duration.js for canvas recording - Update library_html5audio.js (MediaStreamAudioDestinationNode) - Add --pre-js for recordVideo/fix-webm in config.emscripten.default.mk - Original PR: openframeworks#7553
Cherry-picked from Jonathhhan/audioWorklet-3 - Update html5audio to audioWorklet (AudioContext 44100, MediaStreamAudioDestinationNode, emscriptenRegisterAudioObject) - Rewrite ofxEmscriptenSoundStream to use emscripten_create_wasm_audio_worklet_node - Update sound examples to 128 buffer, fix mutex to std::mutex - Add USE_PTHREADS, AUDIO_WORKLET, WASM_WORKERS flags for 6.x (adapted for 6.0.6) - Original PR: openframeworks#7727
danoli3
force-pushed
the
emscripten-combined
branch
from
September 11, 2026 11:21
0b26f61 to
64763cc
Compare
WASM_WORKERS=1 + AUDIO_WORKLET=1 with MAIN_MODULE=1 fails on 6.0.6. Use MAIN_MODULE=2 (dynamic) which allows WASM_WORKERS. Keeps WASM_WORKERS perf for audioWorklet while allowing MAIN_MODULE.
Member
Author
|
Dropping WASM_WORKERS in light of -s AUDIO_WORKLET=1 - fixes MAIN_MODULE issues |
danoli3
marked this pull request as draft
September 12, 2026 04:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined Emscripten PRs, cherry-picked with original author (Jonathhhan) and adapted for 6.0.6: