Add CI support for building Windows on ARM wheels#1143
Conversation
| install_requires = [ | ||
| 'numpy<2.0; python_version<"3.9"', | ||
| 'numpy(>=2, <2.3.0); python_version>="3.9"', | ||
| 'numpy(>=2, <=2.3.1); python_version>="3.9"', |
There was a problem hiding this comment.
Hi @asmorkalov
Just to note here that these changes become obsolete if this PR got merged.
There was a problem hiding this comment.
Unless I'm missing something big, couldn't .github/workflows/build_wheels_windows_arm.yml be replaced (avoiding tons of duplication that one could forget to update across configs) by updating strategy.matrix and strategy.matrix.include ?
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
python-version: ['3.11']
platform: [x86, x64, arm64]
with_contrib: [0, 1]
without_gui: [0, 1]
build_sdist: [0]
include:
- os: 'windows-2025'
- platform: 'arm64'
os: 'windows-11-arm'There was a problem hiding this comment.
Similar here
runs-on: ${{ matrix.os }}
defaults:
run:
shell: cmd
strategy:
fail-fast: false
matrix:
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
platform: [x86, x64, arm64]
with_contrib: [0, 1]
without_gui: [0, 1]
build_sdist: [0]
include:
- os: 'windows-2025'
- platform: 'arm64'
os: 'windows-11-arm'
exclude:
# actions/setup-python does not provide prebuilt arm64 Python before 3.11
- platform: arm64
python-version: "3.7"
- platform: arm64
python-version: "3.8"
- platform: arm64
python-version: "3.9"
- platform: arm64
python-version: "3.10"Co-authored-by: Avasam <samuel.06@hotmail.com>
|
Hi @Avasam, I've addressed all the review comments and made the requested changes. Please let me know if there's anything else needed from my side to help move this PR toward merging. Thanks! |
|
Hi @asmorkalov & @Avasam |
|
I'm not a maintainer here. Just a contributor like you who's trying to get the best out of OpenCV-Python. Hopefully you get this merged soon because I could also really use it. |
PR Description:
Changes Proposed: