Return extracted SpanContext when it is sampled but invalid#8634
Draft
thswlsqls wants to merge 1 commit into
Draft
Return extracted SpanContext when it is sampled but invalid#8634thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
thswlsqls
force-pushed
the
fix/opentracing-shim-extract-sampled-spancontext
branch
from
July 17, 2026 06:04
fb11ef4 to
8ffae0e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8634 +/- ##
=========================================
Coverage 91.64% 91.64%
- Complexity 10348 10349 +1
=========================================
Files 1013 1013
Lines 27380 27382 +2
Branches 3218 3220 +2
=========================================
+ Hits 25092 25094 +2
Misses 1558 1558
Partials 730 730 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thswlsqls
force-pushed
the
fix/opentracing-shim-extract-sampled-spancontext
branch
from
July 18, 2026 01:00
8ffae0e to
8db6342
Compare
Pull request dashboard status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5339
Description
extractto return aSpanContextShim if the context is valid, is sampled, or carries non-emptyBaggage.Propagation.extractTextMapimplemented only theisValidandBaggageterms, so an invalid but sampled context was dropped as null.isSampledterm to match the spec code block. Invalid but sampled contexts supportjaeger-debug-idheaders, which force propagation of debug information.Baggagestill returns null.Testing done
TracerShimTest#extract_invalidButSampledSpanContext: a test propagator extracts an invalid but sampledSpanContext, andextractreturns a non-null, sampledSpanContextShim. Fails without thePropagationchange../gradlew :opentracing-shim:check— 84 tests passed.## UnreleasedCHANGELOG entry.Propagationis package-private and no public signature changed, so no apidiff update was generated.