Skip to content

Consistent json property#8563

Merged
jack-berg merged 4 commits into
open-telemetry:mainfrom
jack-berg:consistent-json-property
Jul 2, 2026
Merged

Consistent json property#8563
jack-berg merged 4 commits into
open-telemetry:mainfrom
jack-berg:consistent-json-property

Conversation

@jack-berg

Copy link
Copy Markdown
Member

Related to #8402.

Currently, @JsonProperty annotations are inconsistent:

  • For serialization, they are dupllicated, appearing on both fields and on getters
  • For deserialization, they only exist on fields. The setters (or with* in this case), do not have annotations. This mean that jackson has to use reflection to discover / leverage annotations on private fields.

With this PR, we remove annotations from the fields, favoring including them on only the getters and setters.

@jack-berg jack-berg requested a review from a team as a code owner July 2, 2026 19:05
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.55%. Comparing base (2626179) to head (7d8181b).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8563      +/-   ##
============================================
+ Coverage     90.96%   91.55%   +0.58%     
- Complexity    10207    10260      +53     
============================================
  Files          1013     1013              
  Lines         27160    27102      -58     
  Branches       3182     3182              
============================================
+ Hits          24706    24812     +106     
+ Misses         1730     1566     -164     
  Partials        724      724              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-berg jack-berg merged commit 4d974ba into open-telemetry:main Jul 2, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants