feat(adls): Add containerName field to ADLS storage connection - #31540
feat(adls): Add containerName field to ADLS storage connection#31540akashverma0786 wants to merge 3 commits into
Conversation
Adds a containerName field to the ADLS connection schema so a specific container can be targeted directly, and regenerates the derived TypeScript types.
akashverma0786
added
safe to test
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
Jest test CoverageUI tests summary
|
✅ Playwright Results — workflow succeededValidated commit ✅ 607 passed · ❌ 0 failed · 🟡 1 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 49m 18s ⏱️ Max setup 1m 47s · max shard execution 17m 6s · max shard-job elapsed before upload 20m 35s · reporting 5s 🌐 215.73 requests/attempt · 2.73 app boots/UI scenario · 13.55% common-shard skew Optimization targets still in progress:
🟡 1 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Code Review ✅ ApprovedAdds the containerName field to the ADLS storage connection schema and regenerates the corresponding TypeScript types. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
|
|
2 participants
Describe your changes:
COLLATE PR: https://github.com/open-metadata/openmetadata-collate/pull/5773
Adds a
containerNamefield to the ADLS storage connection schema so aspecific container can be targeted directly, instead of relying only on
containerFilterPattern.containerName(string, default"") toadlsConnection.json.Type of change:
High-level design:
N/A — small, additive schema field.
Tests:
Use cases covered
containerName.Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
UI screen recording / screenshots:
Not applicable.
Checklist:
make generate.