Skip to content

Add SOLR Facet Query Capabilities - #233

Open
JVickery-TBS wants to merge 2 commits into
canada-v2.10from
feature/solr-facet-queries
Open

Add SOLR Facet Query Capabilities#233
JVickery-TBS wants to merge 2 commits into
canada-v2.10from
feature/solr-facet-queries

Conversation

@JVickery-TBS

Copy link
Copy Markdown

feat(dev): solr facet queries;

  • Added support for solr facet queries.

need this for some fancier "published" status facets in combined Registry.

- Added support for solr facet queries.
- Added change log file.

@wardi wardi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hard to review without knowing more about solr. Do facet queries allow users to bypass permission labels or other checks that would prevent them retrieving data they should not be able to see?

@JVickery-TBS

Copy link
Copy Markdown
Author

@wardi The SOLR facet queries run off of the main results, which include the main q and fq parameters. So doing something like ready_to_publish:true AND +dataset_type:(dataset OR info) in a facet.query would only query the main results (which should already be built via CKAN and our plugin to have the capacity and other permission labels)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants