You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Move audio monitoring out of libobs and make it an output plugin.
Motivation
Currently, when a source is being monitored, a new audio monitor is created for each source. The goal here is to have
a single mix where all of the sources are output to, thus avoiding sync issues when having multiple sources being
monitored.
General comment, outputs and monitoring do not follow the same pipeline atm. Outputs have a much higher latency which can amount to up to 45 audio ticks or 960 ms at 48 kHz; this is obviously tailored for stream outputs in order to sync audio and video as much as possible. But for monitoring this is really bad obviously.
It is possible to reduce the latency for outputs with the low latency option; it reduces the latency to 40 ms so about 2 audio ticks. But this libobs setting affects ALL audio sources. So overall I would say that it is a bad idea to use outputs for monitoring.
A direction which would bypass that difficulty would be to create a new raw_audio callback, for instance raw_direct_monitoring which would mix all monitored sources and feed the mix to a dedicated monitoring output. We would keep the buffering for regular outputs but have the much smaller latency expected from monitoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move audio monitoring out of libobs and make it an output plugin.
Motivation
Currently, when a source is being monitored, a new audio monitor is created for each source. The goal here is to have
a single mix where all of the sources are output to, thus avoiding sync issues when having multiple sources being
monitored.
Link to RFC