Skip to content

fix(ui): show up to 12 partner logos and fix width#8993

Merged
bmuenzenmeyer merged 1 commit into
mainfrom
styfle/fix-partner-logos
Jul 2, 2026
Merged

fix(ui): show up to 12 partner logos and fix width#8993
bmuenzenmeyer merged 1 commit into
mainfrom
styfle/fix-partner-logos

Conversation

@styfle

@styfle styfle commented Jul 2, 2026

Copy link
Copy Markdown
Member

Description

The home page hero renders the small partner list from a weighted shuffle whose
seed changes every 5 minutes, then truncates it to the first 6 entries. With 9
partners in constants.json, each render dropped 3 of them — so depending on
when (or from which cached render) you loaded the page, a given partner's logo
was simply missing. Some wide logos (≈2.2:1 aspect ratio) also rendered about
twice as wide as the roughly square marks next to them. The defined weight
in constants.json did not impact the width of the logo as still doesn't.

Changes

  • Raised SMALL_PARTNER_LIMIT from 6 to 12 so all current partners always
    render; the weighted shuffle still impacts the sort order.
  • Added justify-center to the small partner list so rows stay centered when
    the icons wrap on different viewports.
  • Added max-w-4 to the small partner button SVG. Since the logos have a
    viewBox, wide marks scale down proportionally to fit the cap instead of
    stretching their button, so all partner buttons render at a uniform width.

Validation

  1. Visit the homepage
  2. Notice the partner logos just below the main Get Node and Get Security buttons
  3. Up to 12 are visible (currently 9 visible)
  4. Try again on different viewports/devices

Before

nodejs-org-before

After

nodejs-org-after

Related Issues

None

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@styfle styfle requested a review from a team as a code owner July 2, 2026 01:02
Copilot AI review requested due to automatic review settings July 2, 2026 01:02
@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Jul 2, 2026 1:02am

Request Review

@cursor

cursor Bot commented Jul 2, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Presentation-only CSS and a display limit change on the partner list; no auth, data, or API impact.

Overview
Fixes the homepage hero small partner strip so all current partners can appear and wide favicons no longer dominate the row.

PartnersList raises SMALL_PARTNER_LIMIT from 6 to 12, so the weighted shuffle no longer truncates partners when there are more than six in the catalog. The small list layout adds justify-center so wrapped rows stay centered on narrow viewports. PartnerButton small SVG styling adds max-w-4 alongside fixed height so wide logos scale down and buttons stay a more uniform width.

Reviewed by Cursor Bugbot for commit a2e64a0. Bugbot is set up for automated code reviews on this repo. Configure here.

@avivkeller avivkeller added the fast-track Fast Tracking PRs label Jul 2, 2026
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.35%. Comparing base (104eb57) to head (a2e64a0).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8993      +/-   ##
==========================================
- Coverage   75.41%   75.35%   -0.06%     
==========================================
  Files          98       98              
  Lines        8636     8636              
  Branches      318      319       +1     
==========================================
- Hits         6513     6508       -5     
- Misses       2119     2124       +5     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@avivkeller

Copy link
Copy Markdown
Member

requesting fast track to avoid confusion

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the homepage partners “small” list rendering so all current partners can appear (by increasing the truncation limit) and improves the visual consistency/alignment of partner logo buttons across viewports.

Changes:

  • Increase the small partners truncation limit from 6 to 12 so current partners aren’t omitted due to truncation.
  • Center-align the wrapped small partners row layout with justify-center.
  • Cap small partner SVG max width (max-w-4) to prevent overly wide logos from stretching their button.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
apps/site/components/Common/Partners/index.tsx Raises the small partners list limit to 12 when no explicit length is provided.
apps/site/components/Common/Partners/index.module.css Centers the small partners flex-wrap layout to keep wrapped rows visually balanced.
apps/site/components/Common/Partners/PartnerButton/index.module.css Adds a max-width cap to small SVG logos to normalize button widths for wide marks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bmuenzenmeyer bmuenzenmeyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad this is simple and cosmetic. Good call.

#7991 (comment) and https://github.com/nodejs/nodejs.org/blob/main/docs/partners.md#adding-or-removing-partners make clear that content inclusion-exclusion decisions are not the scope of the website team, and usually come from events like #8973

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Jul 2, 2026
Merged via the queue into main with commit 3bc3b14 Jul 2, 2026
18 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the styfle/fix-partner-logos branch July 2, 2026 02:39
@bjohansebas

Copy link
Copy Markdown
Member

That was actually done intentionally when that part was developed. I don't remember the exact details, but I think it was one of the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants