crypto: add a generic MAC API by panva · Pull Request #65553 · nodejs/node

panva · 2026-08-25T23:57:25Z

Add getMacs() and createMac() to node:crypto as a layer on top of OpenSSL EVP_MAC. Support incremental and streaming operations with provider parameter validation and configurable output sizes.

import { createMac, getMacs, randomBytes } from 'node:crypto';

console.log(getMacs());
// [
//   'blake2bmac', 'blake2smac',
//   'cmac',       'gmac',
//   'hmac',       'kmac-128',
//   'kmac-256',   'kmac128',
//   'kmac256',    'poly1305',
//   'siphash'
// ]

const key = randomBytes(16);
const mac = createMac('CMAC', key, {
  cipher: 'AES-128-CBC',
});

mac.update('some data to authenticate');
console.log(mac.final('hex'));
// 326190b586621ebd6bcb2955c456794d

Refs: #32433
Refs: #40921
Refs: #48314
Refs: #32448
Refs: #32477

Possible followups:

mac.copy([options]) to get a new Mac instance with a copied state, not for GMAC and Poly1305
crypto.mac(algorithm, key, data[, options]) one-shot akin to crypto.hash()

nodejs-github-bot · 2026-08-25T23:57:30Z

Review requested:

@nodejs/crypto
@nodejs/gyp
@nodejs/performance
@nodejs/security-wg

gurgunday

lgtm

panva · 2026-08-26T14:51:16Z

Compared createMac('HMAC', key, { digest: 'SHA256' }) against createHmac('SHA256', key), i.e. 🍏s to 🍏s, using the same binary, a 32-byte key, and 30 interleaved runs. Positive improvement favors createMac().

Operation	Length	Iterations	Confidence	Improvement	Accuracy (*)	(**)	(***)
constructor	0	100,000	***	+13.50%	±1.73%	±2.30%	±3.00%
empty lifecycle	0	250,000	***	+12.35%	±1.82%	±2.43%	±3.18%
lifecycle	0	250,000	***	+14.10%	±1.56%	±2.08%	±2.71%
lifecycle	64	250,000	***	+13.79%	±1.53%	±2.04%	±2.66%
lifecycle	4,096	100,000	***	+5.86%	±1.41%	±1.88%	±2.46%
stream lifecycle	0	100,000	***	+6.56%	±1.44%	±1.92%	±2.50%
stream lifecycle	64	100,000	***	+6.73%	±1.83%	±2.43%	±3.17%
stream lifecycle	4,096	100,000	***	+3.29%	±1.33%	±1.77%	±2.30%
update	64	5,000,000	***	+35.86%	±1.29%	±1.72%	±2.24%
final (Buffer)	64	50,000		-0.36%	±2.08%	±2.77%	±3.61%
final (hex)	64	50,000	***	-13.11%	±1.72%	±2.28%	±2.97%

benchmark/crypto/mac-api-compare.js

'use strict';

const common = require('../common.js');
const assert = require('node:assert');
const {
  createHmac,
  createMac,
} = require('node:crypto');

const implementation = process.env.NODE_MAC_COMPARE_IMPLEMENTATION;
assert(['createHmac', 'createMac'].includes(implementation));

const useMac = implementation === 'createMac';
const key = Buffer.alloc(32, 0x42);
const macOptions = { digest: 'SHA256' };

const bench = common.createBenchmark(main, {
  operation: [
    'constructor',
    'empty-lifecycle',
    'lifecycle',
    'stream-lifecycle',
    'update',
    'final-buffer',
    'final-hex',
  ],
  length: [0, 64, 4096],
  n: [50_000, 100_000, 250_000, 5_000_000],
}, {
  combinationFilter({ operation, length, n }) {
    if (operation === 'constructor')
      return length === 0 && n === 100_000;
    if (operation === 'empty-lifecycle')
      return length === 0 && n === 250_000;
    if (operation === 'lifecycle')
      return n === (length === 4096 ? 100_000 : 250_000);
    if (operation === 'stream-lifecycle')
      return n === 100_000;
    if (operation === 'update')
      return length === 64 && n === 5_000_000;
    if (operation === 'final-buffer' || operation === 'final-hex')
      return length === 64 && n === 50_000;
    return false;
  },
});

function main({ operation, length, n }) {
  const data = Buffer.alloc(length, 0x61);

  switch (operation) {
    case 'constructor':
      measureConstructor(n);
      break;
    case 'empty-lifecycle':
      measureEmptyLifecycle(n);
      break;
    case 'lifecycle':
      measureLifecycle(data, n);
      break;
    case 'stream-lifecycle':
      measureStreamLifecycle(data, n);
      break;
    case 'update':
      measureUpdate(data, n);
      break;
    case 'final-buffer':
      measureFinal(data, n);
      break;
    case 'final-hex':
      measureFinal(data, n, 'hex');
      break;
  }
}

function measureConstructor(n) {
  const contexts = new Array(n);

  if (useMac) {
    createMac('HMAC', key, macOptions).final();
    bench.start();
    for (let i = 0; i < n; ++i)
      contexts[i] = createMac('HMAC', key, macOptions);
  } else {
    createHmac('SHA256', key).digest();
    bench.start();
    for (let i = 0; i < n; ++i)
      contexts[i] = createHmac('SHA256', key);
  }

  bench.end(n);
  assert.strictEqual(typeof contexts[n - 1], 'object');
}

function measureEmptyLifecycle(n) {
  let result;

  if (useMac) {
    createMac('HMAC', key, macOptions).final();
    bench.start();
    for (let i = 0; i < n; ++i)
      result = createMac('HMAC', key, macOptions).final();
  } else {
    createHmac('SHA256', key).digest();
    bench.start();
    for (let i = 0; i < n; ++i)
      result = createHmac('SHA256', key).digest();
  }

  bench.end(n);
  assert(Buffer.isBuffer(result));
}

function measureLifecycle(data, n) {
  let result;

  if (useMac) {
    createMac('HMAC', key, macOptions).update(data).final();
    bench.start();
    for (let i = 0; i < n; ++i)
      result = createMac('HMAC', key, macOptions).update(data).final();
  } else {
    createHmac('SHA256', key).update(data).digest();
    bench.start();
    for (let i = 0; i < n; ++i)
      result = createHmac('SHA256', key).update(data).digest();
  }

  bench.end(n);
  assert(Buffer.isBuffer(result));
}

function measureStreamLifecycle(data, n) {
  let result;

  if (useMac) {
    const warmup = createMac('HMAC', key, macOptions);
    warmup.end(data);
    warmup.read();

    bench.start();
    for (let i = 0; i < n; ++i) {
      const context = createMac('HMAC', key, macOptions);
      context.end(data);
      result = context.read();
    }
  } else {
    const warmup = createHmac('SHA256', key);
    warmup.end(data);
    warmup.read();

    bench.start();
    for (let i = 0; i < n; ++i) {
      const context = createHmac('SHA256', key);
      context.end(data);
      result = context.read();
    }
  }

  bench.end(n);
  assert(Buffer.isBuffer(result));
}

function measureUpdate(data, n) {
  if (useMac) {
    const warmup = createMac('HMAC', key, macOptions);
    warmup.update(data).final();

    const context = createMac('HMAC', key, macOptions);
    bench.start();
    for (let i = 0; i < n; ++i)
      context.update(data);
    bench.end(n);

    assert(Buffer.isBuffer(context.final()));
  } else {
    const warmup = createHmac('SHA256', key);
    warmup.update(data).digest();

    const context = createHmac('SHA256', key);
    bench.start();
    for (let i = 0; i < n; ++i)
      context.update(data);
    bench.end(n);

    assert(Buffer.isBuffer(context.digest()));
  }
}

function measureFinal(data, n, encoding) {
  const contexts = new Array(n);
  let result;

  if (useMac) {
    for (let i = 0; i < n; ++i)
      contexts[i] = createMac('HMAC', key, macOptions).update(data);

    bench.start();
    for (let i = 0; i < n; ++i)
      result = contexts[i].final(encoding);
  } else {
    for (let i = 0; i < n; ++i)
      contexts[i] = createHmac('SHA256', key).update(data);

    bench.start();
    for (let i = 0; i < n; ++i)
      result = contexts[i].digest(encoding);
  }

  bench.end(n);

  if (encoding === undefined)
    assert(Buffer.isBuffer(result));
  else
    assert.strictEqual(typeof result, 'string');
}

                                                                             confidence   improvement   accuracy (*)    (**)   (***)
crypto/mac-api-compare.js n=100000 length=0 operation='constructor'          ***            +13.50 %   ±1.73%  ±2.30%  ±3.00%
crypto/mac-api-compare.js n=250000 length=0 operation='empty-lifecycle'      ***            +12.35 %   ±1.82%  ±2.43%  ±3.18%
crypto/mac-api-compare.js n=250000 length=0 operation='lifecycle'            ***            +14.10 %   ±1.56%  ±2.08%  ±2.71%
crypto/mac-api-compare.js n=250000 length=64 operation='lifecycle'           ***            +13.79 %   ±1.53%  ±2.04%  ±2.66%
crypto/mac-api-compare.js n=100000 length=4096 operation='lifecycle'         ***             +5.86 %   ±1.41%  ±1.88%  ±2.46%
crypto/mac-api-compare.js n=100000 length=0 operation='stream-lifecycle'     ***             +6.56 %   ±1.44%  ±1.92%  ±2.50%
crypto/mac-api-compare.js n=100000 length=64 operation='stream-lifecycle'    ***             +6.73 %   ±1.83%  ±2.43%  ±3.17%
crypto/mac-api-compare.js n=100000 length=4096 operation='stream-lifecycle'  ***             +3.29 %   ±1.33%  ±1.77%  ±2.30%
crypto/mac-api-compare.js n=5000000 length=64 operation='update'             ***            +35.86 %   ±1.29%  ±1.72%  ±2.24%
crypto/mac-api-compare.js n=50000 length=64 operation='final-buffer'                         -0.36 %   ±2.08%  ±2.77%  ±3.61%
crypto/mac-api-compare.js n=50000 length=64 operation='final-hex'            ***            -13.11 %   ±1.72%  ±2.28%  ±2.97%

panva · 2026-08-26T14:52:30Z

Based on the referenced issues and prior work: cc @bnoordhuis @mscdex @tniessen @paragonie-security

codecov · 2026-08-26T18:06:45Z

Codecov Report

❌ Patch coverage is 84.31105% with 115 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.05%. Comparing base (0544741) to head (47e37e6).
⚠️ Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
src/crypto/crypto_mac.cc	78.72%	41 Missing and 49 partials ⚠️
lib/internal/crypto/provider_mac.js	91.60%	22 Missing ⚠️
src/crypto/crypto_mac.h	0.00%	2 Missing ⚠️
lib/internal/crypto/util.js	96.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #65553      +/-   ##
==========================================
- Coverage   90.07%   90.05%   -0.03%     
==========================================
  Files         751      754       +3     
  Lines      254921   255653     +732     
  Branches    48129    48295     +166     
==========================================
+ Hits       229627   230225     +598     
- Misses      16479    16554      +75     
- Partials     8815     8874      +59

Files with missing lines	Coverage Δ
lib/crypto.js	`93.68% <100.00%> (+0.16%)`	⬆️
lib/internal/errors.js	`98.46% <100.00%> (+<0.01%)`	⬆️
src/crypto/crypto_util.h	`66.47% <ø> (ø)`
src/env.cc	`85.30% <100.00%> (-0.13%)`	⬇️
src/env.h	`98.21% <ø> (ø)`
src/node_crypto.cc	`81.81% <ø> (ø)`
src/node_errors.h	`86.95% <ø> (ø)`
lib/internal/crypto/util.js	`97.73% <96.66%> (-0.03%)`	⬇️
src/crypto/crypto_mac.h	`0.00% <0.00%> (ø)`
lib/internal/crypto/provider_mac.js	`91.60% <91.60%> (ø)`
... and 1 more

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-08-26T20:34:52Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @anonrig.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

github-actions · 2026-08-27T15:48:42Z

Benchmark GHA (crypto / mac): https://github.com/nodejs/node/actions/runs/33089847500

Results

[!WARNING]
Do not take GHA benchmark results as face value, always confirm them
using a dedicated machine, e.g. Jenkins CI.

Benchmark results:

                                                                                                     confidence improvement accuracy (*)    (**)   (***)
                                                                                                             NA       NaN %           NA      NA      NA
crypto/create-hmac.js keylen=0 algo='sha1' n=100000                                                                 -0.82 %       ±7.32%  ±9.65% ±12.38%
crypto/create-hmac.js keylen=0 algo='sha256' n=100000                                                                0.17 %       ±7.85% ±10.35% ±13.28%
crypto/create-hmac.js keylen=0 algo='sha512' n=100000                                                                0.78 %       ±7.65% ±10.08% ±12.94%
crypto/create-hmac.js keylen=1024 algo='sha1' n=100000                                                               0.41 %       ±7.63% ±10.06% ±12.90%
crypto/create-hmac.js keylen=1024 algo='sha256' n=100000                                                             0.03 %       ±8.66% ±11.41% ±14.64%
crypto/create-hmac.js keylen=1024 algo='sha512' n=100000                                                             0.13 %       ±7.37%  ±9.72% ±12.47%
crypto/create-hmac.js keylen=16 algo='sha1' n=100000                                                                 1.08 %       ±7.47%  ±9.85% ±12.64%
crypto/create-hmac.js keylen=16 algo='sha256' n=100000                                                               2.13 %       ±8.00% ±10.54% ±13.52%
crypto/create-hmac.js keylen=16 algo='sha512' n=100000                                                               0.88 %       ±7.41%  ±9.77% ±12.53%
crypto/create-hmac.js keylen=64 algo='sha1' n=100000                                                                 0.40 %       ±7.49%  ±9.88% ±12.67%
crypto/create-hmac.js keylen=64 algo='sha256' n=100000                                                               1.06 %       ±7.73% ±10.19% ±13.07%
crypto/create-hmac.js keylen=64 algo='sha512' n=100000                                                               1.10 %       ±7.68% ±10.12% ±12.99%
crypto/hmac-throughput.js api='stream' len=1024 type='asc' keylen=64 algo='sha1' n=500                              -0.37 %       ±6.85%  ±9.03% ±11.58%
crypto/hmac-throughput.js api='stream' len=1024 type='asc' keylen=64 algo='sha256' n=500                            -0.05 %       ±7.58% ±10.00% ±12.83%
crypto/hmac-throughput.js api='stream' len=1024 type='asc' keylen=64 algo='sha512' n=500                            -0.31 %       ±6.54%  ±8.61% ±11.05%
crypto/hmac-throughput.js api='stream' len=1024 type='buf' keylen=64 algo='sha1' n=500                               1.02 %       ±7.11%  ±9.37% ±12.02%
crypto/hmac-throughput.js api='stream' len=1024 type='buf' keylen=64 algo='sha256' n=500                             0.86 %       ±7.41%  ±9.77% ±12.54%
crypto/hmac-throughput.js api='stream' len=1024 type='buf' keylen=64 algo='sha512' n=500                             3.00 %       ±7.18%  ±9.46% ±12.14%
crypto/hmac-throughput.js api='stream' len=1024 type='utf' keylen=64 algo='sha1' n=500                              -1.87 %       ±6.74%  ±8.88% ±11.40%
crypto/hmac-throughput.js api='stream' len=1024 type='utf' keylen=64 algo='sha256' n=500                             1.87 %       ±7.71% ±10.16% ±13.04%
crypto/hmac-throughput.js api='stream' len=1024 type='utf' keylen=64 algo='sha512' n=500                             0.67 %       ±6.78%  ±8.93% ±11.46%
crypto/hmac-throughput.js api='stream' len=102400 type='asc' keylen=64 algo='sha1' n=500                             1.11 %       ±7.10%  ±9.35% ±12.00%
crypto/hmac-throughput.js api='stream' len=102400 type='asc' keylen=64 algo='sha256' n=500                           0.06 %      ±11.16% ±14.71% ±18.88%
crypto/hmac-throughput.js api='stream' len=102400 type='asc' keylen=64 algo='sha512' n=500                           2.07 %       ±8.40% ±11.07% ±14.21%
crypto/hmac-throughput.js api='stream' len=102400 type='buf' keylen=64 algo='sha1' n=500                            -0.81 %       ±7.19%  ±9.48% ±12.16%
crypto/hmac-throughput.js api='stream' len=102400 type='buf' keylen=64 algo='sha256' n=500                           0.89 %      ±11.41% ±15.04% ±19.29%
crypto/hmac-throughput.js api='stream' len=102400 type='buf' keylen=64 algo='sha512' n=500                          -0.02 %       ±8.32% ±10.97% ±14.08%
crypto/hmac-throughput.js api='stream' len=102400 type='utf' keylen=64 algo='sha1' n=500                             0.14 %       ±6.49%  ±8.56% ±10.98%
crypto/hmac-throughput.js api='stream' len=102400 type='utf' keylen=64 algo='sha256' n=500                          -1.02 %      ±10.31% ±13.59% ±17.44%
crypto/hmac-throughput.js api='stream' len=102400 type='utf' keylen=64 algo='sha512' n=500                           0.43 %       ±7.16%  ±9.44% ±12.11%
crypto/hmac-throughput.js api='stream' len=1048576 type='asc' keylen=64 algo='sha1' n=500                           -0.25 %       ±7.11%  ±9.37% ±12.03%
crypto/hmac-throughput.js api='stream' len=1048576 type='asc' keylen=64 algo='sha256' n=500                          0.45 %      ±11.46% ±15.11% ±19.39%
crypto/hmac-throughput.js api='stream' len=1048576 type='asc' keylen=64 algo='sha512' n=500                          1.13 %       ±8.52% ±11.22% ±14.40%
crypto/hmac-throughput.js api='stream' len=1048576 type='buf' keylen=64 algo='sha1' n=500                           -0.93 %       ±7.32%  ±9.65% ±12.38%
crypto/hmac-throughput.js api='stream' len=1048576 type='buf' keylen=64 algo='sha256' n=500                          0.88 %      ±11.54% ±15.21% ±19.51%
crypto/hmac-throughput.js api='stream' len=1048576 type='buf' keylen=64 algo='sha512' n=500                          0.67 %       ±8.55% ±11.28% ±14.47%
crypto/hmac-throughput.js api='stream' len=1048576 type='utf' keylen=64 algo='sha1' n=500                           -0.40 %       ±6.53%  ±8.61% ±11.04%
crypto/hmac-throughput.js api='stream' len=1048576 type='utf' keylen=64 algo='sha256' n=500                         -0.20 %      ±10.42% ±13.74% ±17.63%
crypto/hmac-throughput.js api='stream' len=1048576 type='utf' keylen=64 algo='sha512' n=500                          1.09 %       ±7.21%  ±9.50% ±12.19%
crypto/hmac-throughput.js api='stream' len=2 type='asc' keylen=64 algo='sha1' n=500                                  1.62 %       ±6.68%  ±8.81% ±11.31%
crypto/hmac-throughput.js api='stream' len=2 type='asc' keylen=64 algo='sha256' n=500                                0.56 %       ±6.97%  ±9.18% ±11.78%
crypto/hmac-throughput.js api='stream' len=2 type='asc' keylen=64 algo='sha512' n=500                                1.55 %       ±6.48%  ±8.54% ±10.96%
crypto/hmac-throughput.js api='stream' len=2 type='buf' keylen=64 algo='sha1' n=500                                  0.25 %       ±7.00%  ±9.22% ±11.84%
crypto/hmac-throughput.js api='stream' len=2 type='buf' keylen=64 algo='sha256' n=500                               -0.40 %       ±6.90%  ±9.10% ±11.68%
crypto/hmac-throughput.js api='stream' len=2 type='buf' keylen=64 algo='sha512' n=500                                1.41 %       ±6.96%  ±9.17% ±11.76%
crypto/hmac-throughput.js api='stream' len=2 type='utf' keylen=64 algo='sha1' n=500                                  3.42 %       ±6.77%  ±8.92% ±11.45%
crypto/hmac-throughput.js api='stream' len=2 type='utf' keylen=64 algo='sha256' n=500                                3.91 %       ±7.18%  ±9.46% ±12.14%
crypto/hmac-throughput.js api='stream' len=2 type='utf' keylen=64 algo='sha512' n=500                                5.45 %       ±6.86%  ±9.04% ±11.60%
crypto/hmac-throughput.js api='update' len=1024 type='asc' keylen=64 algo='sha1' n=500                               1.42 %       ±6.63%  ±8.73% ±11.21%
crypto/hmac-throughput.js api='update' len=1024 type='asc' keylen=64 algo='sha256' n=500                             0.07 %       ±8.33% ±10.98% ±14.09%
crypto/hmac-throughput.js api='update' len=1024 type='asc' keylen=64 algo='sha512' n=500                             1.66 %       ±6.42%  ±8.46% ±10.85%
crypto/hmac-throughput.js api='update' len=1024 type='buf' keylen=64 algo='sha1' n=500                              -1.92 %       ±6.37%  ±8.40% ±10.77%
crypto/hmac-throughput.js api='update' len=1024 type='buf' keylen=64 algo='sha256' n=500                             1.13 %       ±8.35% ±11.00% ±14.12%
crypto/hmac-throughput.js api='update' len=1024 type='buf' keylen=64 algo='sha512' n=500                             3.00 %       ±6.51%  ±8.59% ±11.02%
crypto/hmac-throughput.js api='update' len=1024 type='utf' keylen=64 algo='sha1' n=500                              -1.91 %       ±6.54%  ±8.63% ±11.07%
crypto/hmac-throughput.js api='update' len=1024 type='utf' keylen=64 algo='sha256' n=500                            -0.34 %       ±7.66% ±10.10% ±12.96%
crypto/hmac-throughput.js api='update' len=1024 type='utf' keylen=64 algo='sha512' n=500                             0.63 %       ±6.38%  ±8.41% ±10.79%
crypto/hmac-throughput.js api='update' len=102400 type='asc' keylen=64 algo='sha1' n=500                            -0.68 %       ±7.06%  ±9.31% ±11.94%
crypto/hmac-throughput.js api='update' len=102400 type='asc' keylen=64 algo='sha256' n=500                           0.98 %      ±11.47% ±15.11% ±19.39%
crypto/hmac-throughput.js api='update' len=102400 type='asc' keylen=64 algo='sha512' n=500                           1.50 %       ±8.39% ±11.06% ±14.20%
crypto/hmac-throughput.js api='update' len=102400 type='buf' keylen=64 algo='sha1' n=500                            -0.62 %       ±7.08%  ±9.34% ±11.98%
crypto/hmac-throughput.js api='update' len=102400 type='buf' keylen=64 algo='sha256' n=500                          -0.10 %      ±11.52% ±15.18% ±19.48%
crypto/hmac-throughput.js api='update' len=102400 type='buf' keylen=64 algo='sha512' n=500                           0.09 %       ±8.36% ±11.01% ±14.13%
crypto/hmac-throughput.js api='update' len=102400 type='utf' keylen=64 algo='sha1' n=500                            -0.19 %       ±6.53%  ±8.61% ±11.05%
crypto/hmac-throughput.js api='update' len=102400 type='utf' keylen=64 algo='sha256' n=500                          -0.83 %      ±10.47% ±13.79% ±17.70%
crypto/hmac-throughput.js api='update' len=102400 type='utf' keylen=64 algo='sha512' n=500                           0.63 %       ±7.37%  ±9.72% ±12.47%
crypto/hmac-throughput.js api='update' len=1048576 type='asc' keylen=64 algo='sha1' n=500                           -1.12 %       ±7.08%  ±9.33% ±11.98%
crypto/hmac-throughput.js api='update' len=1048576 type='asc' keylen=64 algo='sha256' n=500                          0.62 %      ±11.47% ±15.12% ±19.40%
crypto/hmac-throughput.js api='update' len=1048576 type='asc' keylen=64 algo='sha512' n=500                          1.21 %       ±8.49% ±11.19% ±14.36%
crypto/hmac-throughput.js api='update' len=1048576 type='buf' keylen=64 algo='sha1' n=500                           -1.22 %       ±7.34%  ±9.67% ±12.41%
crypto/hmac-throughput.js api='update' len=1048576 type='buf' keylen=64 algo='sha256' n=500                          0.03 %      ±11.59% ±15.28% ±19.61%
crypto/hmac-throughput.js api='update' len=1048576 type='buf' keylen=64 algo='sha512' n=500                         -0.16 %       ±8.49% ±11.18% ±14.35%
crypto/hmac-throughput.js api='update' len=1048576 type='utf' keylen=64 algo='sha1' n=500                           -1.65 %       ±6.41%  ±8.44% ±10.84%
crypto/hmac-throughput.js api='update' len=1048576 type='utf' keylen=64 algo='sha256' n=500                         -0.67 %      ±10.40% ±13.71% ±17.59%
crypto/hmac-throughput.js api='update' len=1048576 type='utf' keylen=64 algo='sha512' n=500                          0.52 %       ±7.31%  ±9.63% ±12.36%
crypto/hmac-throughput.js api='update' len=2 type='asc' keylen=64 algo='sha1' n=500                                 -1.68 %       ±7.01%  ±9.24% ±11.85%
crypto/hmac-throughput.js api='update' len=2 type='asc' keylen=64 algo='sha256' n=500                               -0.40 %       ±7.19%  ±9.48% ±12.16%
crypto/hmac-throughput.js api='update' len=2 type='asc' keylen=64 algo='sha512' n=500                                1.23 %       ±6.78%  ±8.93% ±11.46%
crypto/hmac-throughput.js api='update' len=2 type='buf' keylen=64 algo='sha1' n=500                                 -0.85 %       ±6.34%  ±8.36% ±10.73%
crypto/hmac-throughput.js api='update' len=2 type='buf' keylen=64 algo='sha256' n=500                                0.79 %       ±6.36%  ±8.38% ±10.76%
crypto/hmac-throughput.js api='update' len=2 type='buf' keylen=64 algo='sha512' n=500                               -0.02 %       ±6.04%  ±7.96% ±10.22%
crypto/hmac-throughput.js api='update' len=2 type='utf' keylen=64 algo='sha1' n=500                                  1.32 %       ±6.56%  ±8.65% ±11.10%
crypto/hmac-throughput.js api='update' len=2 type='utf' keylen=64 algo='sha256' n=500                                1.02 %       ±6.86%  ±9.04% ±11.61%
crypto/hmac-throughput.js api='update' len=2 type='utf' keylen=64 algo='sha512' n=500                                3.15 %       ±6.33%  ±8.34% ±10.70%
crypto/mac.js n=1 length=0 algorithm='hmac-sha256' operation='create-cold'                                   NA       NaN %           NA      NA      NA
crypto/mac.js n=1 length=0 algorithm='hmac-sha256' operation='get-macs-cold'                                 NA       NaN %           NA      NA      NA
crypto/mac.js n=1 length=0 algorithm='kmac-128' operation='create-cold'                                      NA       NaN %           NA      NA      NA
crypto/mac.js n=10000 length=0 algorithm='hmac-sha256' operation='hmac-lifecycle'                            NA       NaN %           NA      NA      NA
crypto/mac.js n=10000 length=0 algorithm='hmac-sha256' operation='mac-lifecycle'                             NA       NaN %           NA      NA      NA
crypto/mac.js n=10000 length=0 algorithm='hmac-sha256' operation='mac-stream-lifecycle'                      NA       NaN %           NA      NA      NA
crypto/mac.js n=10000 length=0 algorithm='kmac-128' operation='mac-lifecycle'                                NA       NaN %           NA      NA      NA
crypto/mac.js n=10000 length=0 algorithm='kmac-128' operation='mac-stream-lifecycle'                         NA       NaN %           NA      NA      NA
crypto/mac.js n=10000 length=4096 algorithm='hmac-sha256' operation='hmac-lifecycle'                         NA       NaN %           NA      NA      NA
crypto/mac.js n=10000 length=4096 algorithm='hmac-sha256' operation='mac-lifecycle'                          NA       NaN %           NA      NA      NA
crypto/mac.js n=10000 length=4096 algorithm='hmac-sha256' operation='mac-stream-lifecycle'                   NA       NaN %           NA      NA      NA
crypto/mac.js n=10000 length=4096 algorithm='kmac-128' operation='mac-lifecycle'                             NA       NaN %           NA      NA      NA
crypto/mac.js n=10000 length=4096 algorithm='kmac-128' operation='mac-stream-lifecycle'                      NA       NaN %           NA      NA      NA
crypto/mac.js n=10000 length=64 algorithm='hmac-sha256' operation='hmac-lifecycle'                           NA       NaN %           NA      NA      NA
crypto/mac.js n=10000 length=64 algorithm='hmac-sha256' operation='mac-lifecycle'                            NA       NaN %           NA      NA      NA
crypto/mac.js n=10000 length=64 algorithm='hmac-sha256' operation='mac-stream-lifecycle'                     NA       NaN %           NA      NA      NA
crypto/mac.js n=10000 length=64 algorithm='kmac-128' operation='mac-lifecycle'                               NA       NaN %           NA      NA      NA
crypto/mac.js n=10000 length=64 algorithm='kmac-128' operation='mac-stream-lifecycle'                        NA       NaN %           NA      NA      NA
crypto/mac.js n=20000 length=0 algorithm='hmac-sha256' operation='create-warm'                               NA       NaN %           NA      NA      NA
crypto/mac.js n=20000 length=0 algorithm='kmac-128' operation='create-warm'                                  NA       NaN %           NA      NA      NA
crypto/mac.js n=20000 length=64 algorithm='hmac-sha256' operation='final-buffer'                             NA       NaN %           NA      NA      NA
crypto/mac.js n=20000 length=64 algorithm='hmac-sha256' operation='final-hex'                                NA       NaN %           NA      NA      NA
crypto/mac.js n=500000 length=0 algorithm='hmac-sha256' operation='get-macs-warm'                            NA       NaN %           NA      NA      NA
crypto/mac.js n=500000 length=64 algorithm='hmac-sha256' operation='stream'                                  NA       NaN %           NA      NA      NA
crypto/mac.js n=500000 length=64 algorithm='hmac-sha256' operation='update'                                  NA       NaN %           NA      NA      NA
crypto/mac.js n=500000 length=64 algorithm='kmac-128' operation='stream'                                     NA       NaN %           NA      NA      NA
crypto/mac.js n=500000 length=64 algorithm='kmac-128' operation='update'                                     NA       NaN %           NA      NA      NA
crypto/webcrypto-hmac.js n=1000 len=0 keylen=512 keyReuse='shared' mode='parallel' hash='SHA-1'                     -0.31 %      ±10.74% ±14.15% ±18.16%
crypto/webcrypto-hmac.js n=1000 len=0 keylen=512 keyReuse='shared' mode='parallel' hash='SHA-256'                   -0.68 %      ±10.70% ±14.11% ±18.10%
crypto/webcrypto-hmac.js n=1000 len=0 keylen=512 keyReuse='shared' mode='parallel' hash='SHA-512'                   -2.21 %      ±10.69% ±14.09% ±18.08%
crypto/webcrypto-hmac.js n=1000 len=0 keylen=512 keyReuse='shared' mode='serial' hash='SHA-1'                        0.55 %      ±11.61% ±15.31% ±19.64%
crypto/webcrypto-hmac.js n=1000 len=0 keylen=512 keyReuse='shared' mode='serial' hash='SHA-256'                      0.13 %      ±11.59% ±15.28% ±19.60%
crypto/webcrypto-hmac.js n=1000 len=0 keylen=512 keyReuse='shared' mode='serial' hash='SHA-512'                      0.05 %      ±11.50% ±15.16% ±19.45%
crypto/webcrypto-hmac.js n=1000 len=0 keylen=512 keyReuse='unique' mode='parallel' hash='SHA-1'                      2.85 %      ±11.11% ±14.64% ±18.79%
crypto/webcrypto-hmac.js n=1000 len=0 keylen=512 keyReuse='unique' mode='parallel' hash='SHA-256'                    0.33 %      ±10.62% ±14.00% ±17.96%
crypto/webcrypto-hmac.js n=1000 len=0 keylen=512 keyReuse='unique' mode='parallel' hash='SHA-512'                   -3.30 %      ±10.39% ±13.69% ±17.57%
crypto/webcrypto-hmac.js n=1000 len=256 keylen=512 keyReuse='shared' mode='parallel' hash='SHA-1'                   -1.42 %      ±10.55% ±13.90% ±17.84%
crypto/webcrypto-hmac.js n=1000 len=256 keylen=512 keyReuse='shared' mode='parallel' hash='SHA-256'                  0.23 %      ±11.09% ±14.61% ±18.75%
crypto/webcrypto-hmac.js n=1000 len=256 keylen=512 keyReuse='shared' mode='parallel' hash='SHA-512'                  2.12 %      ±11.47% ±15.12% ±19.40%
crypto/webcrypto-hmac.js n=1000 len=256 keylen=512 keyReuse='shared' mode='serial' hash='SHA-1'                      0.22 %      ±11.58% ±15.26% ±19.59%
crypto/webcrypto-hmac.js n=1000 len=256 keylen=512 keyReuse='shared' mode='serial' hash='SHA-256'                   -0.70 %      ±11.31% ±14.91% ±19.13%
crypto/webcrypto-hmac.js n=1000 len=256 keylen=512 keyReuse='shared' mode='serial' hash='SHA-512'                   -1.87 %      ±11.38% ±14.99% ±19.24%
crypto/webcrypto-hmac.js n=1000 len=256 keylen=512 keyReuse='unique' mode='parallel' hash='SHA-1'                    0.64 %      ±11.09% ±14.61% ±18.75%
crypto/webcrypto-hmac.js n=1000 len=256 keylen=512 keyReuse='unique' mode='parallel' hash='SHA-256'                 -0.73 %      ±10.56% ±13.92% ±17.87%
crypto/webcrypto-hmac.js n=1000 len=256 keylen=512 keyReuse='unique' mode='parallel' hash='SHA-512'                  1.73 %      ±10.86% ±14.32% ±18.37%
crypto/webcrypto-hmac.js n=1000 len=4096 keylen=512 keyReuse='shared' mode='parallel' hash='SHA-1'                  -1.88 %      ±11.20% ±14.77% ±18.95%
crypto/webcrypto-hmac.js n=1000 len=4096 keylen=512 keyReuse='shared' mode='parallel' hash='SHA-256'                -2.05 %      ±10.62% ±14.00% ±17.96%
crypto/webcrypto-hmac.js n=1000 len=4096 keylen=512 keyReuse='shared' mode='parallel' hash='SHA-512'                -2.50 %      ±11.17% ±14.72% ±18.89%
crypto/webcrypto-hmac.js n=1000 len=4096 keylen=512 keyReuse='shared' mode='serial' hash='SHA-1'                     1.11 %      ±11.10% ±14.63% ±18.78%
crypto/webcrypto-hmac.js n=1000 len=4096 keylen=512 keyReuse='shared' mode='serial' hash='SHA-256'                  -0.26 %      ±11.12% ±14.66% ±18.81%
crypto/webcrypto-hmac.js n=1000 len=4096 keylen=512 keyReuse='shared' mode='serial' hash='SHA-512'                   0.77 %      ±10.69% ±14.09% ±18.08%
crypto/webcrypto-hmac.js n=1000 len=4096 keylen=512 keyReuse='unique' mode='parallel' hash='SHA-1'                  -1.25 %      ±11.04% ±14.55% ±18.67%
crypto/webcrypto-hmac.js n=1000 len=4096 keylen=512 keyReuse='unique' mode='parallel' hash='SHA-256'                -0.46 %      ±10.74% ±14.16% ±18.17%
crypto/webcrypto-hmac.js n=1000 len=4096 keylen=512 keyReuse='unique' mode='parallel' hash='SHA-512'                 2.15 %      ±11.89% ±15.68% ±20.11%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 139 comparisons, you can thus
expect the following amount of false-positive results:
  6.95 false positives, when considering a   5% risk acceptance (*, **, ***),
  1.39 false positives, when considering a   1% risk acceptance (**, ***),
  0.14 false positives, when considering a 0.1% risk acceptance (***)

[!WARNING]
Do not take GHA benchmark results as face value, always confirm them
using a dedicated machine, e.g. Jenkins CI.

panva · 2026-08-28T15:21:04Z

I don't know what to do about these consistent crypto unrelated failures on rhel8-x64.

not ok 598 sea/test-single-executable-application
  ---
  duration_ms: 9143.24700
  severity: fail
  exitcode: 1
  stack: |-
    Copied /home/iojs/build/workspace/node/out/Release/node to /home/iojs/node-tmp/.tmp.598/sea
    Injected /home/iojs/node-tmp/.tmp.598/snapshot.blob into /home/iojs/node-tmp/.tmp.598/sea
    [process 226290]: --- stderr ---
    
    [process 226290]: --- stdout ---
    
    [process 226290]: status = null, signal = SIGSEGV
    /home/iojs/build/workspace/node/test/common/child_process.js:112
        throw error;
        ^
    
    Error: - process terminated with status null, expected 0
    - process terminated with signal SIGSEGV, expected null
        at Object.<anonymous> (/home/iojs/build/workspace/node/test/sea/test-single-executable-application.js:23:1)
        at Module._compile (node:internal/modules/cjs/loader:1937:14)
        at Object..js (node:internal/modules/cjs/loader:2077:10)
        at Module.load (node:internal/modules/cjs/loader:1659:32)
        at Module._load (node:internal/modules/cjs/loader:1451:12)
        at wrapModuleLoad (node:internal/modules/cjs/loader:261:19)
        at Module.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:154:5)
        at node:internal/main/run_main_module:33:47 {
      options: {
        env: {
          COMMON_DIRECTORY: '/home/iojs/build/workspace/node/test/common',
          NODE_DEBUG_NATIVE: 'SEA'
        }
      },
      command: '/home/iojs/node-tmp/.tmp.598/sea -a --b=c d'
    }
    
    Node.js v27.0.0-pre
  ...

not ok 5794 node-api/test_sea_addon/test
  ---
  duration_ms: 9358.74300
  severity: fail
  exitcode: 1
  stack: |-
    Copied /home/iojs/build/workspace/node/out/Release/node to /home/iojs/node-tmp/.tmp.5793/sea
    Injected /home/iojs/node-tmp/.tmp.5793/sea-prep.blob into /home/iojs/node-tmp/.tmp.5793/sea
    [process 297002]: --- stderr ---
    
    [process 297002]: --- stdout ---
    
    [process 297002]: status = null, signal = SIGSEGV
    /home/iojs/build/workspace/node/test/common/child_process.js:112
        throw error;
        ^
    
    Error: - process terminated with status null, expected 0
    - process terminated with signal SIGSEGV, expected null
        at Object.<anonymous> (/home/iojs/build/workspace/node/test/node-api/test_sea_addon/test.js:35:1)
        at Module._compile (node:internal/modules/cjs/loader:1937:14)
        at Object..js (node:internal/modules/cjs/loader:2077:10)
        at Module.load (node:internal/modules/cjs/loader:1659:32)
        at Module._load (node:internal/modules/cjs/loader:1451:12)
        at wrapModuleLoad (node:internal/modules/cjs/loader:261:19)
        at Module.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:154:5)
        at node:internal/main/run_main_module:33:47 {
      options: {
        env: { NODE_DEBUG_NATIVE: 'SEA' },
        cwd: '/home/iojs/node-tmp/.tmp.5793'
      },
      command: '/home/iojs/node-tmp/.tmp.5793/sea '
    }
    
    Node.js v27.0.0-pre
  ...

panva · 2026-08-28T15:31:15Z

Assisted-by: Codex

This is a deterministic ELF-layout bug in legacy postject, not a crash in the new MAC implementation.

The MAC PR changes the final node executable’s section sizes, even though the failing tests never use the MAC API.
The two failing tests are the only remaining tests using legacy generateSEA():
- test/sea/test-single-executable-application.js
- test/node-api/test_sea_addon/test.js
generateSEA() invokes the vendored postject injector.
For this executable layout, postject’s LIEF copy produces overlapping PT_LOAD page ranges.
RHEL8’s 4.18 kernel refuses the overlapping mapping and kills the executable during execve, before Node runs. This explains the empty stdout/stderr and immediate SIGSEGV.

The kernel diagnostic was:

elf segment ... requested but the memory is mapped already

See nodejs/build#4433.

Why it happens on every resume

The failure is layout-dependent, not random. Rebuilding the same source with the same RHEL8 compiler/linker produces the same ELF layout, so postject selects the same problematic gap every time.

Across different commits it may appear intermittent, but for this particular PR layout it is consistently reproducible.

Previous runs

72528: same two SEA failures
72536: infrastructure timeout; inconclusive
72543: same two SEA failures
72548: same two SEA failures
72549: same two SEA failures
72556: reproduced the same failure again

The failure followed the RHEL8 label across IBM and DigitalOcean workers, while adjacent unrelated RHEL8 builds passed.

Why the existing fix does not cover it

Node.js PR #65564 fixes this for the native --build-sea implementation by relocating the program-header table after .bss.

These two tests still use generateSEA() and postject, so they do not go through that fixed path. PR #65564 explicitly notes that the postject-based tests remain uncovered.

Proper fix

Either:

migrate these last two tests from generateSEA() to buildSEA(), or
update postject with the equivalent ELF program-header relocation fix.

Repeated resumes, rebasing onto the same main revision, or changing code size may alter the layout accidentally, but none addresses the underlying bug.

Add getMacs() and createMac() to node:crypto as a layer on top of OpenSSL EVP_MAC. Support incremental and streaming operations with provider parameter validation and configurable output sizes. Signed-off-by: Filip Skokan <panva.ip@gmail.com>

Migrate the remaining SEA tests away from postject. This routes ELF generation through --build-sea, which keeps PT_LOAD segments on separate pages for compatibility with RHEL 8 kernels. Assisted-by: Codex Signed-off-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot · 2026-08-28T16:13:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76645/

Add getMacs() and createMac() to node:crypto as a layer on top of OpenSSL EVP_MAC. Support incremental and streaming operations with provider parameter validation and configurable output sizes. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65553 Refs: #32433 Refs: #40921 Refs: #48314 Refs: #32448 Refs: #32477 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Migrate the remaining SEA tests away from postject. This routes ELF generation through --build-sea, which keeps PT_LOAD segments on separate pages for compatibility with RHEL 8 kernels. Assisted-by: Codex Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65553 Refs: #32433 Refs: #40921 Refs: #48314 Refs: #32448 Refs: #32477 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

panva · 2026-08-28T22:58:38Z

Landed in 4215cc3...249e6ff

Migrate the remaining SEA tests away from postject. This routes ELF generation through --build-sea, which keeps PT_LOAD segments on separate pages for compatibility with RHEL 8 kernels. Assisted-by: Codex Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: nodejs#65553 Refs: nodejs/build#4433 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Add getMacs() and createMac() to node:crypto as a layer on top of OpenSSL EVP_MAC. Support incremental and streaming operations with provider parameter validation and configurable output sizes. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65553 Refs: #32433 Refs: #40921 Refs: #48314 Refs: #32448 Refs: #32477 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Migrate the remaining SEA tests away from postject. This routes ELF generation through --build-sea, which keeps PT_LOAD segments on separate pages for compatibility with RHEL 8 kernels. Assisted-by: Codex Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65553 Refs: nodejs/build#4433 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Aug 25, 2026

jasnell reviewed Aug 26, 2026

View reviewed changes

Comment thread src/crypto/crypto_mac.cc Outdated

jasnell approved these changes Aug 26, 2026

View reviewed changes

jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 26, 2026

gurgunday approved these changes Aug 26, 2026

View reviewed changes

panva added the crypto Issues and PRs related to the crypto subsystem. label Aug 26, 2026

panva marked this pull request as ready for review August 26, 2026 14:51

panva requested review from bnoordhuis and tniessen August 26, 2026 14:51

anonrig approved these changes Aug 26, 2026

View reviewed changes

anonrig added the notable-change PRs with changes that should be highlighted in changelogs. label Aug 26, 2026

panva removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2026

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

aduh95 approved these changes Aug 28, 2026

View reviewed changes

gurgunday approved these changes Aug 28, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

panva mentioned this pull request Aug 28, 2026

node-test-commit-linux on 'rhel8-x64' is failing since 2026-08-20 nodejs/build#4433

Closed

panva added 2 commits August 28, 2026 17:46

crypto: add a generic MAC API

c9bea8a

Add getMacs() and createMac() to node:crypto as a layer on top of OpenSSL EVP_MAC. Support incremental and streaming operations with provider parameter validation and configurable output sizes. Signed-off-by: Filip Skokan <panva.ip@gmail.com>

panva added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label Aug 28, 2026

panva force-pushed the crypto-provider-macs branch from 76541f0 to 47e37e6 Compare August 28, 2026 16:12

sxa mentioned this pull request Aug 28, 2026

Auto Start CI delayed running 2 - 3 hours instead of every 5 minutes nodejs/build#4443

Closed

panva closed this Aug 28, 2026

panva deleted the crypto-provider-macs branch August 28, 2026 22:58

Uh oh!

Uh oh!

Conversation

panva commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 25, 2026

Uh oh!

Uh oh!

gurgunday left a comment

Choose a reason for hiding this comment

Uh oh!

panva commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

panva commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Aug 26, 2026

Uh oh!

github-actions Bot commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment was marked as outdated.

This comment has been minimized.

panva commented Aug 28, 2026

Uh oh!

panva commented Aug 28, 2026

Why it happens on every resume

Previous runs

Why the existing fix does not cover it

Proper fix

Uh oh!

nodejs-github-bot commented Aug 28, 2026

Uh oh!

panva commented Aug 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

panva commented Aug 25, 2026 •

edited

Loading

panva commented Aug 26, 2026 •

edited

Loading

panva commented Aug 26, 2026 •

edited

Loading

codecov Bot commented Aug 26, 2026 •

edited

Loading

github-actions Bot commented Aug 27, 2026 •

edited

Loading