sqlite: throw on disposal of an in-use session - #65449
Open
araujogui wants to merge 1 commit into
Open
Conversation
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65449 +/- ##
==========================================
+ Coverage 90.11% 90.12% +0.01%
==========================================
Files 752 752
Lines 252317 252318 +1
Branches 47432 47435 +3
==========================================
+ Hits 227376 227409 +33
+ Misses 16259 16216 -43
- Partials 8682 8693 +11
🚀 New features to boost your workflow:
|
Renegade334
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
session[Symbol.dispose]()wrappedSession::Close()in av8::TryCatchand discarded whatever it threw, so the in-use guard added by #65349 rejected the close but the exception never reached JavaScript. Disposing a session while it is generating a changeset or patchset appeared to succeed and left the session open, and[Symbol.dispose]()disagreed withclose()about a state both should reject.Session::Dispose()no longer delegates throughClose(). It follows the same shape asStatementSync::Dispose(): return early when the session is already closed, then apply the in-use guard and letERR_INVALID_STATEpropagate. Dropping the "database is not open" check is intentional —DatabaseSync::Close()runsDeleteSessions()first, so a session on a closed database is already closed and disposal stays a no-op there.Fixes: #65447
Refs: #65349