Split oversized test file test/parallel/test-fs-promises-file-handle-writer.js (1117 lines ->170 lines ) - #65384
Open
BboyAkers wants to merge 1 commit into
Open
Split oversized test file test/parallel/test-fs-promises-file-handle-writer.js (1117 lines ->170 lines )#65384BboyAkers wants to merge 1 commit into
BboyAkers wants to merge 1 commit into
Conversation
nodejs-github-bot
added
needs-ci
jasnell
reviewed
Aug 18, 2026
| @@ -0,0 +1,81 @@ | |||
| const { | |||
Member
There was a problem hiding this comment.
These need the 'use strict'; at the top and the require('../common')
Member
There was a problem hiding this comment.
These should be caught by running make lint
Member
|
Your commits will need to be squashed to a single commit that has the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65384 +/- ##
==========================================
- Coverage 90.29% 90.07% -0.22%
==========================================
Files 759 752 -7
Lines 247628 251861 +4233
Branches 46687 47309 +622
==========================================
+ Hits 223593 226869 +3276
- Misses 15483 16323 +840
- Partials 8552 8669 +117 🚀 New features to boost your workflow:
|
Split the oversized test file test-fs-promises-file-handle-writer.js (1117 lines) into smaller, focused test files: - test-fs-promises-file-handle-pipeto.js - test-fs-promises-file-handle-writer-abort.js - test-fs-promises-file-handle-writer-dispose.js - test-fs-promises-file-handle-writer-lifecycle.js - test-fs-promises-file-handle-writer-limits-validation.js - test-fs-promises-file-handle-writer-pipeline.js - test-fs-promises-file-handle-writer-sync.js Signed-off-by: Austin Akers <austin.akers5@gmail.com>
Author
|
Done!! @jasnell 🙂 |
avivkeller
added
the
code-and-learn
avivkeller
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split oversized test file
test/parallel/test-fs-promises-file-handle-writer.js(1117 lines -> 170 lines).Split the test cases into focused test files:
test-fs-promises-file-handle-pipeto.jstest-fs-promises-file-handle-writer-abort.jstest-fs-promises-file-handle-writer-dispose.jstest-fs-promises-file-handle-writer-lifecycle.jstest-fs-promises-file-handle-writer-limits-validation.jstest-fs-promises-file-handle-writer-pipeline.jstest-fs-promises-file-handle-writer-sync.jstest-fs-promises-file-handle-writer.js(retained core write / writev tests)Was AI used? If yes, why?
Yes, I used AI to: