permission: keep parent allowlist when Worker execArgv is empty - #65359
Open
yunshingng wants to merge 2 commits into
Open
permission: keep parent allowlist when Worker execArgv is empty#65359yunshingng wants to merge 2 commits into
yunshingng wants to merge 2 commits into
Conversation
When execArgv is set explicitly (including []), workers no longer inherit the parent's CLI flags. Re-attach Permission Model flags from the parent so empty/modified execArgv does not drop filesystem allowlists. Signed-off-by: yunshingng <yunshingng25@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
- Use only primordials in ensurePermissionFlagsInExecArgv - Improve flag presence checks for --flag and --flag=value forms - Align regression test with parallel test style (common, isMainThread) Signed-off-by: yunshingng <yunshingng25@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Under
--permission, creating aWorkerwithexecArgv: []could drop the parent's filesystem allowlist compared to a defaultWorker.This change re-attaches parent Permission Model flags when
execArgvis provided explicitly (including an empty array).Test plan
test/parallel/test-permission-worker-empty-execargv.jscc @RafaelGSS