Skip to content

lib,src: remove --no-experimental-websocket CLI flag - #65284

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:no-experimental-websocket
Aug 23, 2026
Merged

lib,src: remove --no-experimental-websocket CLI flag#65284
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:no-experimental-websocket

Conversation

@aduh95

@aduh95 aduh95 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@aduh95 aduh95 added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 14, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Aug 14, 2026
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (3781ebc) to head (e50bbc8).
⚠️ Report is 125 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65284      +/-   ##
==========================================
+ Coverage   90.11%   90.14%   +0.02%     
==========================================
  Files         752      752              
  Lines      251820   251810      -10     
  Branches    47351    47346       -5     
==========================================
+ Hits       226923   226985      +62     
+ Misses      16223    16163      -60     
+ Partials     8674     8662      -12     
Files with missing lines Coverage Δ
lib/internal/process/pre_execution.js 97.59% <ø> (+0.44%) ⬆️
src/node_options.cc 79.53% <100.00%> (+0.07%) ⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread doc/api/globals.md Outdated
Comment thread doc/api/globals.md Outdated
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
aduh95 force-pushed the no-experimental-websocket branch from efd37f1 to e50bbc8 Compare August 17, 2026 13:25
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@avivkeller avivkeller added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 23, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
   ✘  semver-major requires at least 2 TSC approvals

The pull request was removed from the Commit Queue and labeled commit-queue-failed An error occurred while landing this pull request using GitHub Actions. . After resolving the failure, remove that label and add commit-queue Add this label to land a pull request using GitHub Actions. to retry.

Full Commit Queue output
- Loading data for nodejs/node/pull/65284
✔  Done loading data for nodejs/node/pull/65284
----------------------------------- PR info ------------------------------------
Title      lib,src: remove `--no-experimental-websocket` CLI flag (#65284)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:no-experimental-websocket -> nodejs:main
Labels     c++, semver-major, process, needs-ci, commit-queue, config
Commits    1
 - lib,src: remove `--no-experimental-websocket` CLI flag
Committers 1
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65284
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65284
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 14 Aug 2026 10:14:58 GMT
   ✔  Approvals: 3
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/65284#pullrequestreview-4937960901
   ✔  - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/65284#pullrequestreview-4938752316
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65284#pullrequestreview-4952085701
   ✘  semver-major requires at least 2 TSC approvals
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-08-23T14:02:40Z: https://ci.nodejs.org/job/node-test-pull-request/76291/
- Querying data for job/node-test-pull-request/76291/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

@trivikr

trivikr commented Aug 23, 2026

Copy link
Copy Markdown
Member

cc @nodejs/tsc as this PR needs another approval from a TSC member because of semver-major label.

@panva panva added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 23, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 057e591 into nodejs:main Aug 23, 2026
82 of 83 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 057e591

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants