doc: remove obsolete --napi-modules doc entry#64220
Open
legendecas wants to merge 1 commit into
Open
Conversation
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
8840aa8 to
94da503
Compare
lpinca
approved these changes
Jun 30, 2026
edsadr
approved these changes
Jun 30, 2026
geeksilva97
approved these changes
Jun 30, 2026
Collaborator
Collaborator
Collaborator
Collaborator
HarshithaKP
approved these changes
Jul 1, 2026
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64220 β Done loading data for nodejs/node/pull/64220 ----------------------------------- PR info ------------------------------------ Title doc: remove obsolete --napi-modules doc entry (#64220) β Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch legendecas:cli-napi-modules -> nodejs:main Labels node-api, author ready, needs-ci Commits 1 - doc: remove obsolete --napi-modules doc entry Committers 1 - Chengzhong Wu <cwu631@bloomberg.net> PR-URL: https://github.com/nodejs/node/pull/64220 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64220 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> -------------------------------------------------------------------------------- βΉ This PR was created on Tue, 30 Jun 2026 18:52:29 GMT β Approvals: 4 β - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/64220#pullrequestreview-4603771320 β - Adrian Estrada (@edsadr): https://github.com/nodejs/node/pull/64220#pullrequestreview-4603915973 β - Edy Silva (@geeksilva97): https://github.com/nodejs/node/pull/64220#pullrequestreview-4604828357 β - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/64220#pullrequestreview-4610678742 β Last GitHub CI successful βΉ Last Full PR CI on 2026-07-01T14:52:45Z: https://ci.nodejs.org/job/node-test-pull-request/74493/ - Querying data for job/node-test-pull-request/74493/ β Build data downloaded β Last Jenkins CI successful -------------------------------------------------------------------------------- β No git cherry-pick in progress β No git am in progress β No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD β origin/main is now up-to-date - Downloading patch for 64220 From https://github.com/nodejs/node * branch refs/pull/64220/merge -> FETCH_HEAD β Fetched commits as b2e83150cb54..94da5035468e -------------------------------------------------------------------------------- Auto-merging doc/api/cli.md [main 41b4e7f163] doc: remove obsolete --napi-modules doc entry Author: Chengzhong Wu <cwu631@bloomberg.net> Date: Tue Jun 30 14:49:37 2026 -0400 4 files changed, 2 insertions(+), 15 deletions(-) β Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- doc: remove obsolete --napi-modules doc entry
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--napi-moduleshas been a no-op for a long time. Remove it from the doc.It is still kept as a no-op option.