build: allow linting node.1

[avivkeller]

Adds make doc/node.1 without triggering it on normal builds

[aduh95]

Wait, it looks like it needs internet access, which is a problem for integrators who run the tests in a sandbox, and also completely irrelevant for node.1:

UNDICI 59249: connecting to raw.githubusercontent.com using https:undefined
UNDICI 59249: connecting to raw.githubusercontent.com using https:undefined
UNDICI 59249: connection to raw.githubusercontent.com using https:undefined errored - No such binding: crypto
UNDICI 59249: connection to raw.githubusercontent.com using https:undefined errored - No such binding: crypto
UNDICI 59249: request to GET https://raw.githubusercontent.com/nodejs/node/HEAD/CHANGELOG.md errored - No such binding: crypto
UNDICI 59249: request to GET https://raw.githubusercontent.com//nodejs/node/HEAD/CHANGELOG.md errored - No such binding: crypto
[08:04:00.088] ERROR: fetch failed

I got rid of it by commenting out the following in tools/doc/node_modules/@node-core/doc-kit/src/utils/configuration/index.mjs:

        changelog: populate(CHANGELOG_URL, {
          repository: 'nodejs/node',
          ref: 'HEAD',
        }),

[aduh95]

Another problem I've seen is that if I update node.1 manually, it's going to tell me doc/node.1 is out of date; run `make doc/node.1` to regenerate it. However, trying to run it:

$ make doc/node.1 
make: 'doc/node.1' is up to date.

Should we recommend rm doc/node.1 && make doc/node.1?

[aduh95]

I was getting frustrated not understanding why me changing manually doc/node.1 would not trigger an error when running make test-doc -j, turns out it's because it's not listed as a dep.
I've found the following diff providing better UX:

diff --git a/Makefile b/Makefile
index 963d0456fb0..e1f8bb5155e 100644
--- a/Makefile
+++ b/Makefile
@@ -935,2 +935,2 @@ out/doc/apilinks.json: $(wildcard lib/*.js) tools/doc/node_modules | out/doc
-.PHONY: doc/node.1
-doc/node.1: doc/api/cli.md tools/doc/node_modules
+.PHONY: node.1
+node.1: doc/api/cli.md tools/doc/node_modules
@@ -944 +944 @@ doc/node.1: doc/api/cli.md tools/doc/node_modules
-			-o $(@D) \
+			-o doc \
@@ -1496 +1496 @@ tools/.mdlintstamp: tools/lint-md/node_modules/remark-parse/package.json $(LINT_
-tools/.manpagelintstamp: doc/api/cli.md tools/doc/node_modules
+tools/.manpagelintstamp: doc/api/cli.md tools/doc/node_modules doc/node.1
@@ -1508 +1508 @@ tools/.manpagelintstamp: doc/api/cli.md tools/doc/node_modules
-			echo 'doc/node.1 is out of date; run `make doc/node.1` to regenerate it.'; \
+			echo 'doc/node.1 is out of date; run `make node.1` to regenerate it.'; \

[avivkeller]

Applied your patch! I'll update doc-kit to correctly output make node.1 not make doc/node.1

[avivkeller]

Thanks for all your help, @aduh95!