Skip to content

test: fix missing cb in fs.unlink - #3368

Merged
gengjiawen merged 1 commit into
nodejs:mainfrom
legendecas:test-fs-unlink
Sep 10, 2026
Merged

test: fix missing cb in fs.unlink#3368
gengjiawen merged 1 commit into
nodejs:mainfrom
legendecas:test-fs-unlink

Conversation

@legendecas

@legendecas legendecas commented Sep 9, 2026

Copy link
Copy Markdown
Member

Fix CI failure in nodejs/gyp-next#357.

  1) addon
       build simple addon in path with non-ascii characters:
     TypeError [ERR_INVALID_ARG_TYPE]: The "cb" argument must be of type function. Received undefined
      at makeCallback (node:fs:186:3)
      at Object.unlink (node:fs:1989:14)
      at Context.<anonymous> (test\test-addon.js:114:10)
      at process.processTicksAndRejections (node:internal/process/task_queues:104:5)

Checklist
  • npm install && npm run lint && npm test passes
  • tests are included

@gengjiawen
gengjiawen merged commit e91cd76 into nodejs:main Sep 10, 2026
71 of 72 checks passed
@legendecas
legendecas deleted the test-fs-unlink branch September 10, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants