Update collabora_docker.sh for CODE 26#2821
Merged
Merged
Conversation
Fixes CollaboraOnline/online#15918 Adds explicit ProxyPass for /cool/ws to restore WebSocket compatibility with CODE 26
Fixes CollaboraOnline/online#15918 Adds explicit ProxyPass for /cool/ws to restore WebSocket compatibility with CODE 26
Member
|
@swaan Thanks for the PR! Please comply with DCO, thanks! |
The vhost is generated from an unquoted heredoc, so $1 must be escaped
as \$1 to survive shell expansion (same as \${APACHE_LOG_DIR} above).
Without the escape the generated Apache config reads /cool//ws and the
legacy websocket URL is never proxied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)