fix(rows): let file picker and smart picker open above row modals #2515 - #2912
Open
foolfitz wants to merge 2 commits into
Open
fix(rows): let file picker and smart picker open above row modals #2515#2912foolfitz wants to merge 2 commits into
foolfitz wants to merge 2 commits into
Conversation
The row modals overrode .modal-mask to z-index 9999, one level above the NcModal default of 9998. Since NcModal teleports to body, pickers opened from a rich text cell shared that stacking context and always painted underneath. CreateRow.vue carried the same override as EditRow.vue. Fixes nextcloud#2515 Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: foolfitz <foolfitz@gmail.com>
|
Did you try different use case ? see #2126 |
enjeck
reviewed
Aug 25, 2026
enjeck
left a comment
enjeck
left a comment
Contributor
There was a problem hiding this comment.
what Aveyron-RetD said above. Please attach screenshots showing the various cases.
Right now, i think we have a "deadlock" where if we have this, we're sacrificing the other
|
For me this bug is not present on 33.0.6 tables app 2.2.1 |
Author
|
I made some screenshots. Tables editing
Embed a nextcloud table in Text
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The row modals overrode .modal-mask to z-index
9999, one level above the NcModal default of9998. Since NcModal teleports to body, pickers opened from a rich text cell shared that stacking context and always painted underneath.CreateRow.vuecarried the same override asEditRow.vue.Fixes #2515
Assisted-by: ClaudeCode:claude-opus-5
馃 AI (if applicable)