🕵️ Add sharereview support - #2711
Merged
Merged
Conversation
AndyScherzinger
added
enhancement
AndyScherzinger
force-pushed
the
feat/noid/sharereview
branch
from
June 7, 2026 13:34
a74331b to
411e1f7
Compare
AndyScherzinger
marked this pull request as ready for review
June 7, 2026 18:35
AndyScherzinger
added
3. to review
AndyScherzinger
force-pushed
the
feat/noid/sharereview
branch
2 times, most recently
from
June 11, 2026 15:39
569f563 to
b35b188
Compare
enjeck
reviewed
Jun 15, 2026
AndyScherzinger
force-pushed
the
feat/noid/sharereview
branch
5 times, most recently
from
June 15, 2026 22:08
d53e2d8 to
d2e8862
Compare
enjeck
reviewed
Jun 17, 2026
enjeck
left a comment
enjeck
left a comment
Contributor
There was a problem hiding this comment.
To be sure, it's intentional to be able to delete shares from resources that you don't own/manage? And that usually-secret public share tokens are listed too?
blizzz
requested changes
Jun 17, 2026
AndyScherzinger
added
2. developing
Member
Author
|
@enjeck regarding:
Yes BUT I will change the implementation in the way that it uses an event mechanism like in other places with similar calling patterns, to ensure the user would have that permission as checked then by the share review app. SO I reset the PR to draft, to reflect the need for further improvements. |
AndyScherzinger
marked this pull request as draft
June 19, 2026 19:57
AndyScherzinger
force-pushed
the
feat/noid/sharereview
branch
3 times, most recently
from
June 22, 2026 17:10
873b425 to
e8dc75a
Compare
8 tasks
AndyScherzinger
force-pushed
the
feat/noid/sharereview
branch
from
June 25, 2026 16:55
e8dc75a to
affa711
Compare
AndyScherzinger
force-pushed
the
feat/noid/sharereview
branch
3 times, most recently
from
July 2, 2026 07:11
15ceadf to
b0444a4
Compare
AndyScherzinger
force-pushed
the
feat/noid/sharereview
branch
5 times, most recently
from
July 15, 2026 23:18
ad3985f to
390d769
Compare
blizzz
marked this pull request as ready for review
August 14, 2026 13:29
AndyScherzinger
force-pushed
the
feat/noid/sharereview
branch
from
August 14, 2026 15:23
390d769 to
c7652bb
Compare
…review apps via OCP\Share\ShareReview Implement IShareReviewSource listing all tables(table/view/context) shares with their capabilities mapped to ShareReviewPermission entries, streaming share rows from the database via a generator to keep the memory footprint low on large instances, gate deletions behind the ShareReviewAccessCheckEvent authorization check with share-delete activity entries for auditability, and register the source via RegisterShareReviewSourceEvent. Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
blizzz
force-pushed
the
feat/noid/sharereview
branch
from
August 19, 2026 17:35
c7652bb to
54565ef
Compare
Member
|
rebased and resolved the conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)