fix(ContextChat): add suitable attributes to the public api - #63750
Open
kyteinsky wants to merge 1 commit into
Open
fix(ContextChat): add suitable attributes to the public api#63750kyteinsky wants to merge 1 commit into
kyteinsky wants to merge 1 commit into
Conversation
kyteinsky
requested review from
Altahrim,
leftybournes and
salmart-dev
and removed request for
a team
August 28, 2026 01:32
8 tasks
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
kyteinsky
force-pushed
the
fix/context-chat-add-implementable
branch
from
August 28, 2026 12:22
991f9c1 to
3afae1d
Compare
edward-ly
requested changes
Aug 28, 2026
| /** | ||
| * @since 32.0.0 | ||
| */ | ||
| #[Consumable(since: '32.0.0')] |
Contributor
There was a problem hiding this comment.
should be Implementable?
Contributor
Author
There was a problem hiding this comment.
was looking at these docs, how they envision the usage of these attributes: https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/api.html
Consumable seems to be meant for direct use via dependency injection, while Implementable should be implemented.
or did you mean that IContentManager can be implemented by apps other than context_chat?
Contributor
There was a problem hiding this comment.
Ah I see, I initially thought all interfaces had to be Implementable or something like that, ignore me then
| /** | ||
| * @since 32.0.0 | ||
| */ | ||
| #[Implementable(since: '32.0.0')] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add attributes to the public context chat api to make the purpose and api compatibility clearer.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)