Skip to content

perf(db): drop redundant db-side migrations version sorting #61707

Merged
AndyScherzinger merged 3 commits into
masterfrom
jtr/db-migrationService
Jul 2, 2026
Merged

perf(db): drop redundant db-side migrations version sorting #61707
AndyScherzinger merged 3 commits into
masterfrom
jtr/db-migrationService

Conversation

@joshtrichards

@joshtrichards joshtrichards commented Jul 1, 2026

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

Since we sort in PHP in the way we want to, the db-side sorting is just extra CPU burn.

Notes:

  • The only real change here is line 179
  • The other changes are just some tech debt/cleanup:
    • the addition of runtime typing (that was partially missing throughout the class).
    • updating of the comments for createMigrationTable() since it has some serious side effects worth knowing about.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added this to the Nextcloud 35 milestone Jul 1, 2026
@joshtrichards joshtrichards marked this pull request as ready for review July 2, 2026 02:36
@joshtrichards joshtrichards requested a review from a team as a code owner July 2, 2026 02:36
@joshtrichards joshtrichards requested review from Altahrim, ArtificialOwl, icewind1991 and leftybournes and removed request for a team July 2, 2026 02:36
@joshtrichards joshtrichards added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 2, 2026
@joshtrichards joshtrichards added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 2, 2026
@AndyScherzinger AndyScherzinger merged commit 03bd626 into master Jul 2, 2026
241 of 286 checks passed
@AndyScherzinger AndyScherzinger deleted the jtr/db-migrationService branch July 2, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: database Database related DB feature: install and update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants