Skip to content

feat(media-player): enhancement - #16525

Merged
alperozturk96 merged 69 commits into
masterfrom
feat/enhance-player
Sep 7, 2026
Merged

feat(media-player): enhancement#16525
alperozturk96 merged 69 commits into
masterfrom
feat/enhance-player

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Feb 16, 2026

Copy link
Copy Markdown
Collaborator

Original PR: #16116

This merge request adds a persistent "queue" / playlist feature to the Nextcloud Media Player and implements a set of frequently requested playback behaviors and UI improvements:

  • Shuffle mode (randomize playback order)
  • Repeat modes (repeat one / repeat all / off)
  • Automatically play the next file when the current media ends (so folders with mixed content will behave as playlists containing only media files)
  • Automatic filtering to exclude non-media files when generating a playlist from a folder
  • Improved media player notification controls while the app is minimized (skip to next / previous, play/pause)
    The proposed implementation has been used in the HiDrive application for a long time.
image

Changes

Removes old media playback classes since new PlayerActivity and it's new dependencies responsible for playing music and video.

How to test?

  • Try to play audio file
  • Try to play downloaded audio file
  • Try to play video file
  • Try to play downloaded video file
  • Try to play video file press back and check PIP mode
  • From file list try to open any media file and swipe left or right video must be played with new player also images should be reachable
  • From media tab try to open any media file and swipe left or right video must be played with new player also images should be reachable

@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 🤖 🍏 Mobile clients team Feb 17, 2026
@tobiasKaminsky tobiasKaminsky moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 🤖 🍏 Mobile clients team Feb 17, 2026
@alperozturk96 alperozturk96 added this to the Nextcloud App 33.1.0 milestone Mar 18, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Apr 7, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Apr 23, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Apr 23, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Apr 23, 2026
@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/24839731997/artifacts/6604944467
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
alperozturk96 force-pushed the feat/enhance-player branch from 40fbefe to 12e12fd Compare May 4, 2026 06:31
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/25304554595/artifacts/6777860093
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96

Copy link
Copy Markdown
Collaborator Author

@AlexViseven Can you update the license headers? We are using AGPL-3.0-or-later.

@alperozturk96
alperozturk96 force-pushed the feat/enhance-player branch from 12e12fd to cabb92c Compare May 21, 2026 12:45
@alperozturk96

Copy link
Copy Markdown
Collaborator Author

@tobiasKaminsky @AlexViseven

I think BackgroundPlayerService is becomes unnecessary after this enhancement?

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/26226778620/artifacts/7136775925
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AlexViseven

AlexViseven commented May 21, 2026

Copy link
Copy Markdown
Contributor

@AlexViseven Can you update the license headers? We are using AGPL-3.0-or-later.

@alperozturk96 done in #17078

@alperozturk96
alperozturk96 force-pushed the feat/enhance-player branch from f35bee9 to 01369fd Compare May 22, 2026 06:00
@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/26271258182/artifacts/7153865887
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/26439410086/artifacts/7211811022
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

alperozturk96 and others added 12 commits September 6, 2026 17:44
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/34043270465/artifacts/9992423459
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness5858
Dodgy code195195
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3737
Security1919
Total373373

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness5858
Dodgy code195195
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3737
Security1919
Total373373

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/34044849077/artifacts/9992881058
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@daniele-verducci

Copy link
Copy Markdown
Contributor

@alperozturk96 @tobiasKaminsky hey, I fixed all the bugs I could find, so this is ready to review on my part.
There are things that can be improved, but imho now there shouldn't be nothing evident to the user, so this could be merged and maybe included in RC2.

@alperozturk96 alperozturk96 added performance 🚀 Performance improvement opportunities (non-crash related) AI assisted labels Sep 7, 2026
@alperozturk96
alperozturk96 merged commit 59f3255 into master Sep 7, 2026
23 of 26 checks passed
@alperozturk96
alperozturk96 deleted the feat/enhance-player branch September 7, 2026 06:27
@github-project-automation github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 🤖 🍏 Mobile clients team Sep 7, 2026
@szaimen

szaimen commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🎉🎉🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted performance 🚀 Performance improvement opportunities (non-crash related)

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

6 participants