Skip to content

ci: Improve codestyle check diff output - #178

Merged
igorkorsukov merged 1 commit into
musescore:mainfrom
juli27:improveCiCodestyleOutput
Aug 3, 2026
Merged

ci: Improve codestyle check diff output#178
igorkorsukov merged 1 commit into
musescore:mainfrom
juli27:improveCiCodestyleOutput

Conversation

@juli27

@juli27 juli27 commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Let git diff write its output directly to stdout (inherited from CMake) instead of taking the detour through CMake's message system.

Keep a FATAL_ERROR at the end to exit the CMake process with an error.

before:

        The required changes are...
    
CMake Error at buildscripts/ci/checkcodestyle/checkcodestyle.cmake:56 (message):
  diff --git a/framework/shortcuts_v2/qml/Muse/Shortcuts/shortcutsmodel.cpp
  b/framework/shortcuts_v2/qml/Muse/Shortcuts/shortcutsmodel.cpp

  index 515045e..fc3bb9f 100644

  --- a/framework/shortcuts_v2/qml/Muse/Shortcuts/shortcutsmodel.cpp

  +++ b/framework/shortcuts_v2/qml/Muse/Shortcuts/shortcutsmodel.cpp

  @@ -176,7 +176,7 @@ void ShortcutsModel::load()

               searchKeyItems << QString::fromStdString(action.code)
                              << action.title.qTranslatedWithoutMnemonic()
                              << action.description.qTranslated()

  - item.searchKey = searchKeyItems.join(u' ');

  + item.searchKey = searchKeyItems.join(u' ');

   
               m_items.append(item);
           }

after:

        The required changes are...
    
diff --git a/framework/shortcuts_v2/qml/Muse/Shortcuts/shortcutsmodel.cpp b/framework/shortcuts_v2/qml/Muse/Shortcuts/shortcutsmodel.cpp
index 515045e..fc3bb9f 100644
--- a/framework/shortcuts_v2/qml/Muse/Shortcuts/shortcutsmodel.cpp
+++ b/framework/shortcuts_v2/qml/Muse/Shortcuts/shortcutsmodel.cpp
@@ -176,7 +176,7 @@ void ShortcutsModel::load()
             searchKeyItems << QString::fromStdString(action.code)
                            << action.title.qTranslatedWithoutMnemonic()
                            << action.description.qTranslated()
-            item.searchKey = searchKeyItems.join(u' ');
+                item.searchKey = searchKeyItems.join(u' ');
 
             m_items.append(item);
         }
CMake Error at buildscripts/ci/checkcodestyle/checkcodestyle.cmake:52 (message):
  codestyle check failed


  • I signed the CLA as username:
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.
  • I created a unit test or vtest to verify the changes I made (if applicable).

Let git diff write its output directly to stout (inherited from CMake)
instead of taking the detour through CMake's message system.

Keep a FATAL_ERROR at the end to exit the CMake process with an error.
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@juli27, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 05779113-7b45-42df-806d-d8dff4fd2b14

📥 Commits

Reviewing files that changed from the base of the PR and between ed33fa3 and a01eede.

📒 Files selected for processing (1)
  • buildscripts/ci/checkcodestyle/checkcodestyle.cmake

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Jojo-Schmitz

Copy link
Copy Markdown
Contributor

A long awaited fix, finally makes the code style check usefull again, at least as far as whitespace is concerned. but that is the code style check's main purpose.

@igorkorsukov
igorkorsukov merged commit 6adb702 into musescore:main Aug 3, 2026
3 checks passed
@juli27
juli27 deleted the improveCiCodestyleOutput branch August 3, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants