PolylinePlot - additional options - #176
Merged
mathesoncalum merged 2 commits intoAug 4, 2026
Merged
Conversation
- Allow disabling of ghost points - Implement basics of selected points
This was referenced Jul 31, 2026
grliszas14
approved these changes
Aug 3, 2026
grliszas14
added a commit
to audacity/audacity
that referenced
this pull request
Aug 5, 2026
This PR updates `PolylinePlot` usage in accordance with musescore/muse_framework#176
7 tasks
kryksyh
added a commit
to audacity/audacity
that referenced
this pull request
Aug 12, 2026
Resolves: backports changes from master to beta 3 List of PRs: - #11567 - #11522 - #11553 - #11601 - #11606 - #11617 - #11632 - #11638 framework: - musescore/muse_framework#176 - musescore/muse_framework#210 - musescore/muse_framework#199 deps: - musescore/muse_deps#40 <!-- Use "x" to fill the checkboxes below like [x] --> - [x] I signed [CLA](https://www.audacityteam.org/cla/) - [x] The title of the pull request describes an issue it addresses - [x] If changes are extensive, then there is a sequence of easily reviewable commits - [x] Each commit's message describes its purpose and effects - [x] There are no behavior changes unnecessary for the stated purpose of the PR Recommended: - [ ] Each commit compiles and runs on my machine without known undesirable changes of behavior QA: - [ ] Testflow test cases have been run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tweaks and adds some additional options to our
PolylinePlotcomponent:PolylinePointStylenow contains both the "normal" and "hovered" styles for a given point type. The idea is that, with the introduction of selected points, we should try and keep the number ofPolylinePointStylesto a minimum. This means we can simply declare standard, selected, and ghost point styles instead of having to declare standard normal, standard hovered, selected normal, selected hovered, etc.Build configuration
audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64