chore: remove legacy page-view migration code - #128
Merged
Conversation
alexs-mparticle
force-pushed
the
chore/remove-legacy-migration
branch
from
August 20, 2026 18:37
1659d3a to
39fc6a7
Compare
alexs-mparticle
marked this pull request as ready for review
August 20, 2026 18:54
alexs-mparticle
force-pushed
the
chore/remove-legacy-migration
branch
from
August 27, 2026 14:46
39fc6a7 to
4e6e5ff
Compare
Collaborator
|
🎉 This PR is included in version 1.36.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
migrateLegacyPageViewStorageand theLEGACY_PAGE_VIEWS_KEYconstant. The migration has been live since v1.33.2;migration_retryerrors are < 1% of failures as of 2026-08-19. No active sessions should have the legacympPageViewskey remaining.migrateLegacyPageViewStorageexport and its internal call insideloadPageViewsinsrc/pageViewStorage.tsLEGACY_PAGE_VIEWS_KEYconstant and removed now-unusedreadJSON/removeKeyimportsmigrateLegacyPageViewStorage(this.loggingService)call on the session-end path insrc/Rokt-Kit.tsmigrateLegacyPageViewStoragetests and the "migrates legacy key before reading" test fromtest/src/pageViewStorage.spec.tsloadPageViewsno longer takes aloggingServiceargument (the only use for it was the migration log); callers updatedTest plan
migration_retryerrors after this ships — should be zero🤖 Generated with Claude Code