Skip to content

fix(mgr): declare ms3 via addVueConfig on help page #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
biz87 merged 1 commit into from
Aug 16, 2026
Merged

fix(mgr): declare ms3 via addVueConfig on help page #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions core/components/minishop3/controllers/mgr/help.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,12 @@ public function getLanguageTopics()
*/
public function loadCustomCssJs()
{
// Vue CSS
// Config before Vue modules so mount sees ms3.config (#553).
$this->addVueConfig($this->ms3->config);

$this->addCss($this->ms3->config['assetsUrl'] . 'css/mgr/vue-dist/primeicons.min.css');
$this->addCss($this->ms3->config['assetsUrl'] . 'css/mgr/vue-dist/help.min.css');

// Vue module
$this->addVueModule($this->ms3->config['jsUrl'] . 'mgr/vue-dist/help.min.js');

// Pass config to JavaScript
$this->addHtml('<script>
ms3.config = ' . json_encode($this->ms3->config) . ';
</script>');
}

/**
Expand Down
54 changes: 54 additions & 0 deletions core/components/minishop3/tests/HelpVueEntryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
<?php

/**
* Help mgr page: Vue entry must declare `var ms3` via addVueConfig (#553).
*
* Run: php tests/HelpVueEntryTest.php
*/

declare(strict_types=1);

$fail = static function (string $message): never {
fwrite(STDERR, "FAIL: {$message}\n");
exit(1);
};

$componentRoot = dirname(__DIR__);
$repoRoot = dirname($componentRoot, 3);

$tpl = $componentRoot . '/templates/default/help.tpl';
$tplHtml = is_file($tpl) ? file_get_contents($tpl) : false;
if ($tplHtml === false || !str_contains($tplHtml, 'id="ms3-vue-help"')) {
$fail('help.tpl must contain mount #ms3-vue-help');
}

$controllerPath = $componentRoot . '/controllers/mgr/help.class.php';
$controller = file_get_contents($controllerPath);
if ($controller === false) {
$fail('cannot read help controller');
}

foreach (['help\.min\.js', 'help\.tpl', 'addVueConfig', 'getTemplateFile'] as $pattern) {
if (preg_match('#' . $pattern . '#', $controller) !== 1) {
$fail("help controller must contain /{$pattern}/");
}
}

if (preg_match('#ms3\.config\s*=#', $controller) === 1) {
$fail('help controller must not assign ms3.config without declaring ms3 (#553)');
}

$configPos = strpos($controller, 'addVueConfig');
$modulePos = strpos($controller, 'addVueModule');
if ($configPos === false || $modulePos === false || $configPos > $modulePos) {
$fail('help controller must call addVueConfig() before addVueModule()');
}

$entry = $repoRoot . '/vueManager/src/entries/help.js';
$entrySrc = is_file($entry) ? file_get_contents($entry) : false;
if ($entrySrc === false || !str_contains($entrySrc, '#ms3-vue-help')) {
$fail('help entry must mount #ms3-vue-help');
}

fwrite(STDOUT, "OK HelpVueEntryTest\n");
exit(0);