fix(vue): изоляция ConfirmDialog вкладок Настроек (#548) - #549
Merged
Conversation
Visited Settings tabs and Options+Groups keep multiple ungrouped ConfirmDialogs on the shared PrimeVue bus, so delete shows two dialogs.
This was referenced Aug 13, 2026
VendorsGrid: последовательный двойной confirm при удалении (confirm:true + собственный confirm)
#551
Closed
biz87
added a commit
that referenced
this pull request
Aug 13, 2026
VendorsGrid's ActionsColumn delete action was confirm:true, so useActions showed a confirm and then deleteVendor() showed a second one — a sequential double confirm independent of the shared-bus grouping fixed in #548/#549. Align it to confirm:false like the other settings grids; deleteVendor() remains the single grouped confirm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
На вкладке «Опции» удаление показывает два confirm:
OptionsAndGroupsTabsмонтируетOptionsGridиOptionGroupsGridбез lazy, оба с ungrouped<ConfirmDialog>.SettingsPageдержит посещённые вкладки в DOM, поэтому после обхода доставок/оплат диалогов становится больше.Каждому из семи гридов задан свой
CONFIRM_GROUPна<ConfirmDialog>, во всеconfirm.require, и вuseSelection/ActionsColumnтам, где грид ими пользуется. Паттерн тот же, что #538/#540.Тип изменений
Связанные Issues
Closes #548
Как это было протестировано?
npm run test:smoke, eslint)Конфигурация тестирования:
fix/548-settings-confirm-groupsСкриншоты (если применимо)
Чеклист
npm run lint:ciдля Vue) — eslint по затронутым путямДополнительные заметки
Группы:
settings-options,settings-option-groups,settings-deliveries,settings-payments,settings-statuses,settings-vendors,settings-links.Вне scope: Toast, product-tabs (#539/#543),
uiGroup.js.Ручная проверка: Настройки → Опции → удалить опцию → один confirm. Открыть ещё вкладки, удалить доставку → один confirm.