fix(validators): allow GitLab URLs with nested subgroups#1452
fix(validators): allow GitLab URLs with nested subgroups#1452truecallerabreham wants to merge 1 commit into
Conversation
The gitlabURLRegex only allowed two path segments (owner/repo), rejecting valid GitLab URLs with subgroups like: https://gitlab.com/myorg/team/subgroup/my-mcp-server This is a standard GitLab feature used in GitLab Enterprise. Changes: - Updated regex to allow any number of path segments - Added unit tests for subgroup URLs (1, 2, and 3 levels deep) - Added comprehensive test cases for IsValidRepositoryURL Fixes modelcontextprotocol#1359
|
Thanks for adding subgroup coverage. One thing I think may fail in the new table test: the updated GitLab regex now allows a single path segment ( Maybe the pattern should still require at least two path segments, then allow extra subgroup segments after that, e.g. |
|
Thanks for taking this on! We ended up with two PRs for the same GitLab nested-subgroup fix (this one and #1361). #1361 is passing CI and its regex requires at least owner+repo, whereas the pattern here also matches a single-segment path like |
Summary
The gitlabURLRegex in internal/validators/utils.go only allows two path segments (owner/repo), rejecting valid GitLab URLs with subgroups like:
https://gitlab.com/myorg/team/subgroup/my-mcp-serverGitLab subgroups are a standard feature used in GitLab Enterprise. The current regex prevents self-hosted registries from publishing servers whose source lives in a GitLab group hierarchy.
Changes
Test Plan
Related
Fixes #1359