fix: avoid shell interpretation in MCP dev launcher - #3371
Conversation
|
Thanks for the contribution. This repository only keeps pull requests open when they're linked to an issue that a maintainer has assigned to the author — CONTRIBUTING.md explains why and how we work. This PR has been closed for now because its description doesn't yet link an open issue in this repository (with If there isn't an issue for this yet, please open one — a clear description of the problem is genuinely the most useful thing for us. Then add There's no need to open a new PR — this one will be reopened. While it's closed, please push any updates as new commits rather than force-pushing, since GitHub can't reopen a PR whose branch has been rewritten. Maintainers: reopening this PR, removing the |
|
Research note: the custom query found CWE-78/CWE-94 shell interpretation in the Windows MCP Inspector launcher. The code supplied an argv list but set shell=True on Windows (and used shell=True while probing npx), allowing cmd.exe parsing of argument data. The patch keeps the platform-specific npx executable selection but always uses shell=False. |
Fixes #
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
help wanted, or I'm a maintainer)Additional context