Skip to content

[#386] Rename PascalCase C identifiers to snake_case and add naming c… - #387

Merged
jajik merged 2 commits into
modcluster:mainfrom
rhusar:386-fix-pascal-case
Aug 13, 2026
Merged

[#386] Rename PascalCase C identifiers to snake_case and add naming c…#387
jajik merged 2 commits into
modcluster:mainfrom
rhusar:386-fix-pascal-case

Conversation

@rhusar

@rhusar rhusar commented May 16, 2026

Copy link
Copy Markdown
Member

…onvention CI check

Lets fix this mess.

@jajik jajik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

The CI part needs some changes, and I would prefer it to be in a separate commit. Also, a note in README would be great.

(Also review-wise, maybe it would be better to merge this after JFC reviews #385.)

Comment thread .github/workflows/ci.yml Outdated
@rhusar rhusar added the hold label Jul 21, 2026
@rhusar
rhusar marked this pull request as draft July 21, 2026 13:56
@rhusar

rhusar commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

Making this a draft until we merge the refactor PR.

@jajik

jajik commented Aug 11, 2026

Copy link
Copy Markdown
Member

rhusar and others added 2 commits August 12, 2026 20:47
…d naming convention CI check

Signed-off-by: Radoslav Husar <rhusar@ibm.com>
@rhusar
rhusar force-pushed the 386-fix-pascal-case branch from f39cf0c to df28b72 Compare August 12, 2026 18:47
@rhusar

rhusar commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

@rhusar I used your changes as a base, rebased, and fixed the issues. You'll find it here https://github.com/jajik/mod_proxy_cluster/commits/modcluster-386/, commits 181f8f3 and bd06daa.

On failure: https://github.com/jajik/mod_proxy_cluster/actions/runs/31502987360 On success: https://github.com/jajik/mod_proxy_cluster/actions/runs/31503205277

Thanks, I am swamped ATM; so just cherrypicked your fixes and replaced the PR. Thanks!

@rhusar
rhusar requested a review from jajik August 12, 2026 18:48
@rhusar
rhusar marked this pull request as ready for review August 12, 2026 18:48
@jajik

jajik commented Aug 13, 2026

Copy link
Copy Markdown
Member

Thanks, I am swamped ATM; so just cherrypicked your fixes and replaced the PR. Thanks!

No problem at all. Thanks for the update, I'll merge it shortly.

@jajik
jajik merged commit 62edee0 into modcluster:main Aug 13, 2026
17 checks passed
@rhusar
rhusar deleted the 386-fix-pascal-case branch August 13, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants