Skip to content

feat(load-generator): shuffle agentic conversation start order - #501

Open
arekay-nv wants to merge 2 commits into
mlcommons:mainfrom
arekay-nv:arekay/shuffle_agentic_data
Open

feat(load-generator): shuffle agentic conversation start order#501
arekay-nv wants to merge 2 commits into
mlcommons:mainfrom
arekay-nv:arekay/shuffle_agentic_data

Conversation

@arekay-nv

Copy link
Copy Markdown
Collaborator

What does this PR do?

Shuffles agentic conversation start order using a seeded without-replacement
permutation over conversation indices, matching the default every other perf workload
already uses (agentic previously ran in dataset encounter order). Intra-conversation turn
order is unchanged; ordering is deterministic via dataloader_random_seed (default 42).
Note: agentic perf results are no longer bit-comparable to pre-change runs, with no opt-out
to restore encounter order.

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor/cleanup

Related issues

Testing

  • Tests added/updated
  • All tests pass locally
  • Manual testing completed

Checklist

  • Code follows project style
  • Pre-commit hooks pass
  • Documentation updated (if needed)

Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@github-actions github-actions Bot added the size/normal PR Review Policy: <=500 non-test lines & <=20 files label Sep 10, 2026
@codecov-commenter

codecov-commenter commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@47cc5c8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...c/inference_endpoint/commands/benchmark/execute.py 0.00% 1 Missing ⚠️
...point/load_generator/agentic_inference_strategy.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #501   +/-   ##
=======================================
  Coverage        ?   80.84%           
=======================================
  Files           ?      153           
  Lines           ?    21086           
  Branches        ?        0           
=======================================
  Hits            ?    17046           
  Misses          ?     4040           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arekay-nv
arekay-nv marked this pull request as ready for review September 11, 2026 03:19
@arekay-nv
arekay-nv requested review from a team, hvagadia and leopck September 11, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/normal PR Review Policy: <=500 non-test lines & <=20 files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants