feat(load-generator): shuffle agentic conversation start order - #501
Open
arekay-nv wants to merge 2 commits into
Open
feat(load-generator): shuffle agentic conversation start order#501arekay-nv wants to merge 2 commits into
arekay-nv wants to merge 2 commits into
Conversation
Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
=======================================
Coverage ? 80.84%
=======================================
Files ? 153
Lines ? 21086
Branches ? 0
=======================================
Hits ? 17046
Misses ? 4040
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
arekay-nv
marked this pull request as ready for review
September 11, 2026 03:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Shuffles agentic conversation start order using a seeded without-replacement
permutation over conversation indices, matching the default every other perf workload
already uses (agentic previously ran in dataset encounter order). Intra-conversation turn
order is unchanged; ordering is deterministic via
dataloader_random_seed(default 42).Note: agentic perf results are no longer bit-comparable to pre-change runs, with no opt-out
to restore encounter order.
Type of change
Related issues
Testing
Checklist