Skip to content

test(ts-plugin): return normalized results from the e2e tsserver client - #443

Merged
mizdra merged 1 commit into
mainfrom
simplify-tsserver-client-signatures
Sep 9, 2026
Merged

test(ts-plugin): return normalized results from the e2e tsserver client#443
mizdra merged 1 commit into
mainfrom
simplify-tsserver-client-signatures

Conversation

@mizdra

@mizdra mizdra commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Summary

Test-only change to the ts-plugin e2e test utilities. No behavior change to the plugin itself.

Changes

  • Make the e2e tsserver client return normalized results for Go to Definition, Find All References, Rename, completion, and code fixes
    • Only the fields the tests care about are kept, paths are normalized, and results are sorted by file path then position, so tests can compare them directly with toStrictEqual
  • Move the normalize helpers that tests used to call on both sides of an assertion into the client and stop exporting them
  • Replace the getLoc / getRange fixture helpers with getFileLocation (request arguments) and getFileSpan (expected values, optionally with the enclosing context range)
  • Rewrite expected values in the affected tests in the new form; the set of tests and their expected results are unchanged

How to verify

vp test --project e2e
vp check

Both should pass with the same test count as main (167 passed, 2 todo).

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@mizdra mizdra added the Type: Testing Adding missing tests or correcting existing tests label Sep 9, 2026
@changeset-bot

changeset-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a3b541c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mizdra
mizdra merged commit d2d9403 into main Sep 9, 2026
16 checks passed
@mizdra
mizdra deleted the simplify-tsserver-client-signatures branch September 9, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Testing Adding missing tests or correcting existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant