fix(theme): new-design follow-ups for time-planning, compliance report and review findings - #8065
Merged
Merged
Conversation
…t and review findings Time-planning planning grid (.mtx-grid.time-dashboard): the plugin boxes every header cell and its status classes force !important borders. The header now has only the tint and the bottom line; body day dividers stay but in the row-separator colour, and none against the frame's edges. Compliance report "Rapport" grid (and every mtx-grid): - box-sizing: border-box, so width 100% plus the 1px frame no longer overflows and an overflow: hidden parent stops clipping the right edge. - No mtx divider after left-pinned columns (time-planning keeps its pale one). - Pinned header cells keep the --bg tint against plugin paints. - Thin themed scrollbar on grid scrollers. Review follow-ups (post-merge review of #8061 and Copilot's comments): - Sub-header and px-3 gutter rules scoped to the content card, so the simple-layout connection-setup page keeps its padding. - Backend-configuration case page: its routed div.p-4 root no longer doubles the 24px gutter. - Hand-written mat-mdc-table rows lose the separator under the last row. - Radius token and :is() grouping; icon-button comment made accurate. eForm Classic is unchanged: every rule is scoped to body.theme-workspace. Playwright (shard g): checks the last-row edge, grid box-sizing, the pinned header tint against an injected plugin paint, the full-bleed content-card exception, time-planning dividers and pinned-left dividers. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HfLyiGF7BQTRixiUfSuXxD
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified that would block approval.
Pull request overview
Updates the workspace theme’s table/grid styling and page-gutter handling while preserving Classic theme behavior.
Changes:
- Refines grid borders, pinned cells, scrollbars, radii, and time-planning dividers.
- Scopes gutter overrides to content-card routes and handles backend case-page padding.
- Expands Playwright regression coverage for the updated styles.
File summaries
| File | Description |
|---|---|
| eform-client/src/scss/components/_workspace-utilities.scss | Updated as part of this pull request. |
| eform-client/src/scss/components/_workspace-patterns.scss | Updated as part of this pull request. |
| eform-client/src/scss/components/_workspace-mat-overrides.scss | Updated as part of this pull request. |
| eform-client/playwright/e2e/Tests/g/application-settings.theme-new-design.spec.ts | Updated as part of this pull request. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #8061 ("eForm new design"). CSS only, and every rule is scoped to
body.theme-workspace, so eForm Classic is unchanged.Time-planning planning grid (
.mtx-grid.time-dashboard)The plugin draws a box around every header cell, and its day-status classes (
.white-/.grey-/.green-/.red-background) force borders with!important.Compliance report "Rapport" grid (the first two rules apply to every mtx-grid)
box-sizing: border-box: a width of 100% plus the 1px frame overflowed by 2px, and a parent withoverflow: hiddencut off the right frame edge.--bgtint even when a plugin paints them.The Oversigt and Detaljer tabs of the compliance report need template changes. Those are in a separate backend-configuration plugin PR.
Review follow-ups
These come from the post-merge review of #8061 and from Copilot's comments on it:
px-3gutter rules: now limited to the content card, so the connection-setup page (simple layout, no content card) keeps its padding.div.p-4root no longer doubles the 24px gutter.mat-mdc-tablerows: they lose the separator under the last row.:is()grouping are used, and the icon-button comment is now accurate.Not changed, after checking each comment against the code:
.table-action-trigger, legacymat-rowheights and legacy striping describe CSS or markup that doesn't exist in the app.Note: Nunito Sans weight 500
#8061 added weight 500 to the Nunito Sans link. eForm Classic's own CSS asks for 500 in places, so that text now renders as medium instead of falling back to regular. We're keeping this on purpose.
Tests
New checks in
playwright/e2e/Tests/g/application-settings.theme-new-design.spec.ts:box-sizingThe last three use temporary stand-in markup that is removed after each test.
Verified locally:
ng buildsucceedsplaywright test --listshows 10 testsThe Playwright tests themselves only run in CI. The styles were checked in the browser on a dev tree running the latest
stable.🤖 Generated with Claude Code
https://claude.ai/code/session_01HfLyiGF7BQTRixiUfSuXxD