fix: deleting whitespace#324211
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression in the editor’s word-deletion logic so Ctrl+Del (deleteWordRight) can remove whitespace runs without accidentally deleting comment markers (e.g. //) in mixed multi-cursor alignment scenarios, as described in #245055.
Changes:
- Adjust whitespace-heuristics boundary in
WordOperations._deleteWordRightWhitespaceto trigger even when there is only a single whitespace character before the next non-whitespace character.
Comment on lines
630
to
634
| const firstNonWhitespace = this._findFirstNonWhitespaceChar(lineContent, startIndex); | ||
| if (startIndex + 1 < firstNonWhitespace) { | ||
| if (startIndex < firstNonWhitespace) { | ||
| // bingo | ||
| return new Range(position.lineNumber, position.column, position.lineNumber, firstNonWhitespace + 1); | ||
| } |
chrmarti
previously approved these changes
Jul 3, 2026
alexr00
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #245055
fixes #259145