Add link to native REPL information - #26134
Conversation
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
|
Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Result: Summary: Verification could not run because no trusted sandbox image is configured for `microsoft/vscode-python`, and local execution was not authorized. The PR modifies existing Python and TypeScript tests but adds no new test cases. Linux startup-message behavior lacks coverage because the non-Darwin print test is restricted to Windows. Test runs: 1 not run
|
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
|
Eduardo Villalpando Mello (@edvilme) This is cool - fan of getting people to know what we mean by VS Code Native REPL. |
|
Looking at the missing decoration marker for shell integration.. I wish we had python/cpython#144724 so we can enable shell integration on windows. aka. make: |
Addressed in 516fea5 |
Yes, I agree. Will try to get updates on that, as it would greatly improve the overall experience for users |
|
Adding link for reference: https://aka.ms/python-native-repl |
Fixes #24754
This pull request refactors how shell integration sequences are managed in
python_files/pythonrc.pyby introducing a dedicatedShellIntegrationSequenceenum, and updates related string formatting to use this enum. It also updates user-facing messages in both the Python startup script and the VS Code terminal link provider to include a documentation URL. These changes improve maintainability, clarity, and user guidance.Shell integration refactoring:
ShellIntegrationSequenceenum to centralize shell integration control sequences, replacing hard-coded string literals throughout the code. [1] [2]__str__method in the prompt class to use the new enum values, improving readability and reducing duplication.User guidance improvements:
pythonrc.pyto include a documentation URL, guiding users to more information about the VS Code Native REPL.pythonStartupLinkProvider.tsto match the new message format (excluding the URL), ensuring the link detection logic remains consistent with the Python script output.