chore(deps-dev): bump glob from 7.2.3 to 13.0.6 - #1081
Conversation
082a3ed to
7c404de
Compare
Bumps [glob](https://github.com/isaacs/node-glob) from 7.2.3 to 13.0.6. - [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md) - [Commits](isaacs/node-glob@v7.2.3...v13.0.6) --- updated-dependencies: - dependency-name: glob dependency-version: 13.0.6 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
7c404de to
bc4f1f9
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The dependency bump introduces install-time script considerations and new Node engine constraints, and still leaves glob@7 present via tslint, all of which warrant a deliberate human decision.
Pull request overview
This PR updates the repo’s dev dependency on glob to v13 and adapts the Mocha test runners to the new glob API (named export + Promise-based), helping keep dev tooling up to date and making test discovery deterministic.
Changes:
- Bump
globfrom^7.2.3to^13.0.6and remove@types/glob. - Update test suite runners to use
import { glob } from "glob"and Promise-based file discovery. - Sort discovered test files before adding them to Mocha for stable execution order.
File summaries
| File | Description |
|---|---|
| test/suite/index.ts | Switch to Promise-based glob() and sort test files before running. |
| test/simple-suite/index.ts | Same glob API update + deterministic ordering. |
| test/non-java-gradle-suite/index.ts | Same glob API update + deterministic ordering. |
| test/multiple-suite/index.ts | Same glob API update + deterministic ordering. |
| test/multi-module-suite/index.ts | Same glob API update + deterministic ordering. |
| test/maven-suite/index.ts | Same glob API update + deterministic ordering. |
| test/invisible-suite/index.ts | Same glob API update + deterministic ordering. |
| test/gradle-suite/index.ts | Same glob API update + deterministic ordering. |
| package.json | Bump glob devDependency and drop @types/glob. |
| package-lock.json | Lockfile updates for glob@13 and its new dependency tree (including new engine constraints and nested glob@7 under tslint). |
Review details
- Files reviewed: 9/10 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Changyong Gong (chagong)
left a comment
There was a problem hiding this comment.
Reviewed the glob 13 migration, deterministic test ordering, published package contents, and final CI results.
Changyong Gong (chagong)
left a comment
There was a problem hiding this comment.
Reviewed the glob 13 migration, dependency necessity, published package contents, Node 20 compatibility, deterministic test discovery, and final CI results.
Changyong Gong (chagong)
left a comment
There was a problem hiding this comment.
Reviewed the glob 13 migration, direct dependency necessity, published tarball, Node 20/22 compatibility, deterministic test discovery, local test/package results, and final CI checks.
Bumps glob from 7.2.3 to 13.0.6.
Changelog
Sourced from glob's changelog.
... (truncated)
Commits
e80cb3813.0.69cdbbffrevert tsgo, not ready for test coverage correctness yet89c99bause tsgo compilerb7275d5update deps, expand engines to include node 18942e360update workflows, pull taprc out of package.json4a0d53cupdate tap for mockImport bugfixef94ad2update tap180c2d4update docs37993c8remove stray console.error in test03ae4c213.0.5Maintainer changes
This version was pushed to npm by isaacs, a new releaser for glob since your current version.
Install script changes
This version adds
preparescript that runs during installation. Review the package contents before updating.