Fix the header-only integration recipe in BUILDING.md - #878
Merged
Matthew Parkinson (mjp41) merged 1 commit intoSep 7, 2026
Merged
Conversation
Matthew Parkinson (mjp41)
approved these changes
Sep 7, 2026
Matthew Parkinson (mjp41)
left a comment
Matthew Parkinson (mjp41)
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header-only section of docs/BUILDING.md links
snmalloc_lib, a target that left CMakeLists.txt in the CMake cleanup (#384), and includessrc/snmalloc/override/malloc.cc, a path that resolves neither relative to the caller's file nor on any include path. A project following the recipe verbatim does not build.This links the
snmallocinterface target instead, which putssrcon the include path, and includes the two override files through that path.Verified on a fresh clone of main by extracting the fenced blocks of the section into a consumer project with
[lib_name]replaced by a target name: before the change the build fails at the first include, after it the binary builds, definesmalloc_good_sizeand exits 0. Documentation only.