feat(kernel): Enable Broadcom RoCE driver (bnxt_re) as module on x86_64 - #17874
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to re-enable Broadcom NetXtream RoCE (bnxt_re) by setting CONFIG_INFINIBAND_BNXT_RE=m for the x86_64 Azure Linux kernel build.
Changes:
- Enables
CONFIG_INFINIBAND_BNXT_REas a loadable module in the x86_64 kernel config (currently done in the renderedspecs/output).
2660058 to
7aa380d
Compare
050e1ba to
496ed37
Compare
496ed37 to
cca1682
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
base/comps/kernel/6.18-x86_64-azl.config:6182
- This now conflicts with the checked-in kernel policy: the
kerneloverride still requiresCONFIG_INFINIBAND_BNXT_RE=n(scripts/ci/kernel/kernel-config-checker/kernel_config_checker/kernel_configs_json/azl4-os-required-kernel-configs.json:3234-3238). Because the config-check workflow validates every changed tracked config and kernel-specific overrides replace defaults, this PR will fail CI with expectedn, gotm. Remove or update that stale override so the existing defaultmrequirement applies.
CONFIG_INFINIBAND_BNXT_RE=m
cca1682 to
4349f45
Compare
AZaugg
changed the title
There was a problem hiding this comment.
🟢 Ready to approve
The configuration, policy, release metadata, lock, and rendered outputs are consistent.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
- Files reviewed: 7/8 changed files
- Comments generated: 0 new
- Review effort level: Medium
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
rlmenge
left a comment
rlmenge
left a comment
There was a problem hiding this comment.
Approved. Reviewed the bnxt_re x86_64 module enablement and required-config policy. The kernel was built and booted successfully, and bnxt_re loaded successfully.
Set CONFIG_INFINIBAND_BNXT_RE=m, reenabling RDMA support on Broadcom NetXtreme NICs. Bump azl_pkgrelease to 10 with a %changelog entry and refresh the kernel lock input-fingerprint. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
be06609 to
05da87d
Compare
There was a problem hiding this comment.
🟡 Human review recommended
Kernel module enablement requires human confirmation of successful kernel build and hardware-oriented smoke testing.
Review details
- Files reviewed: 7/8 changed files
- Comments generated: 0 new
- Review effort level: Medium
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
|
/azp run |
|
Azure Pipelines: 3 pipeline(s) were filtered out due to trigger conditions. |
Set CONFIG_INFINIBAND_BNXT_RE=m, reenabling RDMA support on Broadcom NetXtream NICS