.NET: Improving DotNet samples#6869
Merged
Merged
Conversation
…ce generator Replace the direct logger.LogWarning() call (which eagerly evaluates string.Join()) with a [LoggerMessage]-generated extension method in GitHubCopilotAgentLogMessages.cs. Fixes build error: GitHubCopilotAgent.cs(580,13): error CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
giles17
added
documentation
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates several .NET samples to improve out-of-the-box execution, especially around Agent Skills tool approvals and the Foundry OpenAPI tools example.
Changes:
- Added tool-approval middleware with auto-approval rules to the Agent Skills samples so skill tool calls can run without interactive approval prompts.
- Updated the Foundry OpenAPI tools sample to use the Frankfurter exchange-rate API (instead of the countries-by-currency scenario) and refreshed the sample prompt/docs.
- Updated sample verification metadata for the Agent Skills samples and adjusted the expected output description for the OpenAPI tools sample.
Show a summary per file
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI.GitHub.Copilot/GitHubCopilotAgent.cs | Removes an extraneous blank line in session config conversion logic. |
| dotnet/samples/02-agents/AgentSkills/Agent_Step06_McpBasedSkills/Program.cs | Adds tool-approval middleware with auto-approval for skill tools in the MCP-based skills sample. |
| dotnet/samples/02-agents/AgentSkills/Agent_Step01_FileBasedSkills/Program.cs | Adds tool-approval middleware with auto-approval for skill tools in the file-based skills sample. |
| dotnet/samples/02-agents/AgentProviders/foundry/Agent_Step17_OpenAPITools/README.md | Updates the README description to match the new Frankfurter exchange-rate scenario. |
| dotnet/samples/02-agents/AgentProviders/foundry/Agent_Step17_OpenAPITools/Program.cs | Switches the OpenAPI tool definition and prompt to the Frankfurter exchange-rate API. |
| dotnet/eng/verify-samples/AgentsSamples.cs | Updates env-var gating for the skills samples and updates expected output text for the OpenAPI tools sample. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Low
SergeyMenshykh
approved these changes
Jul 2, 2026
westey-m
approved these changes
Jul 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Jul 4, 2026
Open
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing several dotnet samples.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.