.NET: Allow customizing the HarnessAgent shell tool name#6793
Closed
anneheartrecord wants to merge 1 commit into
Closed
.NET: Allow customizing the HarnessAgent shell tool name#6793anneheartrecord wants to merge 1 commit into
anneheartrecord wants to merge 1 commit into
Conversation
HarnessAgent registered the shell tool via AsAIFunction() with the default name run_shell, with no way to change it even though ShellExecutor.AsAIFunction already accepts a name. Add HarnessAgentOptions.ShellToolName and pass it through; null keeps the existing default unchanged.
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a .NET-only configuration knob to HarnessAgent so callers can override the shell tool function name registered via ShellExecutor.AsAIFunction, while preserving the existing default behavior when unset.
Changes:
- Introduced
HarnessAgentOptions.ShellToolName(string?) to optionally customize the model-visible shell tool name. - Updated
HarnessAgentto pass the custom name through toShellExecutor.AsAIFunction(name)only when set; otherwise it keeps the existing parameterless call. - Added a unit test verifying the shell tool is registered under the custom name (and not under
run_shell).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI.Harness/HarnessAgentOptions.cs | Adds ShellToolName option and documents null/default behavior. |
| dotnet/src/Microsoft.Agents.AI.Harness/HarnessAgent.cs | Wires ShellToolName into shell tool registration while preserving the existing default path. |
| dotnet/tests/Microsoft.Agents.AI.Harness.UnitTests/HarnessAgentTests.cs | Adds coverage ensuring the custom tool name is exposed and the default name is not. |
5 tasks
Contributor
|
Thanks for the contribution. This has been superseded by #6880 though, where we also added support for some additional settings in addition to name. So closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HarnessAgentregisters the shell tool withshellExecutor.AsAIFunction(), which always uses the default namerun_shell.ShellExecutor.AsAIFunction(string name = "run_shell", ...)already supports a custom name, butHarnessAgenthad no way to set it. This adds aShellToolNameoption that flows through toAsAIFunction.Closes #6789
Changes
HarnessAgentOptions.ShellToolName(string?, .NET-only, alongside the other shell options). Whennull(default), the executor's own default name is used and behavior is unchanged.HarnessAgentpassesShellToolNametoAsAIFunctionwhen set; otherwise it keeps the parameterless call so the existing default is preserved exactly.Test
ShellExecutor_CustomToolNameIsUsedAsync: setsShellToolNameand asserts the registered tool is exposed under that name (and not underrun_shell). Verified red before the change (tool was stillrun_shell), green after.Microsoft.Agents.AI.Harness.UnitTestssuite passes (82 tests, net10.0).