FIX handle converter preview path inspection errors - #2427
Open
Roman Lutz (romanlutz) wants to merge 1 commit into
Open
FIX handle converter preview path inspection errors#2427Roman Lutz (romanlutz) wants to merge 1 commit into
Roman Lutz (romanlutz) wants to merge 1 commit into
Conversation
Treat filesystem inspection failures as raw media data while preserving serializer errors and existing local file paths. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Comment on lines
+202
to
+203
| except (OSError, ValueError): | ||
| is_existing_file = False |
Contributor
There was a problem hiding this comment.
couldn't there be a value error or os error that is not related to the file existing ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Converter previews inspect
*_pathmedia values to distinguish existing local files from raw base64. Some runtime and filesystem combinations can raiseOSErrororValueErrorwhile inspecting long or invalid path-like values, causing preview serialization to fail before the media is persisted.Treat only those filesystem inspection failures as a non-path result and continue through the existing raw base64 persistence path. Existing local files, URLs, and data URIs retain their current behavior, while serializer and converter errors still propagate.
Tests and Documentation
OSErrorandValueErrorpath inspection failures.