[E-Document] Remove Access = Internal from E-Doc. Data Exchange Impl. codeunit

[Magnus Hartvig Grønbech (Groenbech96)]

Fixes AB#641216

Removes Access = Internal from the E-Doc. Data Exchange Impl. codeunit (6152) so partners can reuse the functions in their own E-Document implementations.

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Security} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

The Access = Internal; property was removed from codeunit 6152 "E-Doc.

Data Exchange Impl." (which implements the "E-Document" interface), widening the codeunit from app-internal to externally accessible. Nothing in this PR's own design docs calls for this change — the plan's "Global Constraints" section explicitly states "All codeunits in this area use Access = Internal" and "No breaking changes to existing behavior," and no other part of the diff depends on this codeunit being externally callable. This looks like an unintentional widening of the object's accessibility surface (e.g. a stray edit or merge artifact) rather than a deliberate design decision; if genuinely unintended, it silently increases the app's public API surface.

Recommendation:

• restore Access = Internal; unless there is a documented reason (not present in this PR) for making the codeunit externally accessible. The real-world impact if unintended would be more than cosmetic (API-surface/compat exposure), so this is flagged for reviewer confirmation before merge even though the agent-finding channel caps its severity at minor.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

codeunit 6152 "E-Doc. Data Exchange Impl." implements "E-Document"
{
    Access = Internal;

_{Agent judgement — not directly backed by a BCQuality knowledge article.}

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

Copilot PR Review

Iteration 4 · Outcome: completed

PR consists of two one-line removals of Access = Internal; from a table and a codeunit (namespace Microsoft.eServices.EDocument.IO.Peppol). No leaf sub-skill found a knowledge-backed or agent-level defect; sibling objects implementing the same 'E-Document' interface (EDocPEPPOLBIS30.Codeunit.al, EDocumentFormat.Enum.al) are already public, so the change appears to be a deliberate consistency fix rather than an accidental API-surface exposure.

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Orchestrator pre-filter (13 file(s) excluded)

• layer-disabled (knowledge) : 13 file(s)

_{Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 2}}$

This diff removes Access = Internal; from codeunit 6152 "E-Doc.

Data Exchange Impl.", changing its default access to Public. The codeunit already declares multiple non-local procedures (Check, Create, CreateBatch, GetBasicInfoFromReceivedDocument, GetCompleteInfoFromReceivedDocument, ExtractHeaderFields, AddFieldToFieldBuffer, GetDataExchangePath) that are now genuinely callable from outside this app for the first time, and none of them carry XML documentation. Per the referenced guidance, public procedures on a now-exposed library codeunit should get <summary>/<param>/<returns> doc comments before the API surface is opened up. Note the sibling implementation "EDoc PEPPOL BIS 3.0" (codeunit 6165) has the same gap, so this is a pattern to address across both, not unique to this file.

Knowledge:

• microsoft/knowledge/style/xmldoc-for-public-library-procedures.md

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 3}}$

The diff removes 'Access = Internal;' from codeunit 6152 "E-Doc.

Data Exchange Impl.", making it a public codeunit for the first time. This exposes 7 public procedures (Check, Create, CreateBatch, GetBasicInfoFromReceivedDocument, GetCompleteInfoFromReceivedDocument, ExtractHeaderFields, AddFieldToFieldBuffer, GetDataExchangePath) as part of the app's public/library surface without any XML documentation comments. Per the referenced guidance, public procedures on a library-role codeunit should carry

// XML docs so external consumers understand intent and preconditions.

Knowledge:

• microsoft/knowledge/style/xmldoc-for-public-library-procedures.md

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.

---

🔄 How to trigger a new status check:

1. 📤 Push a new commit to the PR branch, or
2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

[Magnus Hartvig Grønbech (Groenbech96)]

Copilot pull main into this pr

[Copilot]

Copilot pull main into this pr

Done — I merged main into this PR in commit e592a22e.