Apply micro-ROS patch to upstream Rolling branch - #27
Open
David-LP99 wants to merge 5 commits into
Open
Conversation
* Avoid logging on build time based on RCutils flags (#6) * Add RCL_YAML_PARSER and RCL_LOGGING CMake options. * Replace RCL_YAML_PARSER by RCL_COMMAND_LINE_ENABLED and RCL_LOGGING by RCL_LOGGING_ENABLED. * Disabled logging fix * Fix remapping (#7) Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: julibert <julianbermudez@eprosima.com> Updates 17092020 *Release micro-ROS Foxy (#9) Cleaning Update Add workflow checker Update Test Test Update New approach Update Disable logger name (#11) (#13) (cherry picked from commit 1fac9bf) Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Avoid uint64_t operation when handling context (#16) (#18) * Update Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Update Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Update Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Update Signed-off-by: Pablo Garrido <pablogs9@gmail.com> * Update Signed-off-by: Pablo Garrido <pablogs9@gmail.com> * Clean PR * Clean id rollover check * Fix rollover Co-authored-by: acuadros95 <acuadros1995@gmail.com> (cherry picked from commit 32aa288) Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Update fork checker for Humble Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Update micro-ROS conditional compilation micro-ROS get_type_description fix Signed-off-by: acuadros95 <acuadros1995@gmail.com> micro-ROS get_type_description fix Signed-off-by: acuadros95 <acuadros1995@gmail.com> Revert minor change Signed-off-by: acuadros95 <acuadros1995@gmail.com> Remove vscode file Signed-off-by: acuadros95 <acuadros1995@gmail.com> Address memory issue of type hash Update
…nvironment from micro-ROS (#24) Signed-off-by: Antón Casas <antoncasas@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
|
Tick the box to add this pull request to the merge queue (same as
|
David-LP99
changed the title
David-LP99
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rebases micro-ROS's
rclfork from its stale kilted-era base onto current upstreamros2/rcl(rolling), reapplying the micro-ROS-specific patches (RCL_MICROROS/RCL_MICROROS_COMPLETE_IMPLstripping of arguments parsing, logging/rosout, type-hash, type-description service, and action feedback content-filtering) on top and resolving all merge conflicts.The first 4 commits re-apply the micro-ROS patch to the branch, and the 5th one allows running the test suite, which was not adapted for micro-ROS previously.
Validated by building and running the full
rcl/rcl_action/rcl_lifecycletest suite in arollingcontainer. Along the way, found and fixed several real bugs (not just conflict fallout):rcl_init()never setrmw_init_options.enclaveunderRCL_MICROROS, which crashed everyrcl_init()-dependent test againstrmw_fastrtps_cpp.rcl_subscription_options_t.disable_loaned_messagewas read from uninitialized memory underRCL_MICROROS(an over-broad#ifdefswallowed unrelated env-var logic); now deterministicallytrue.test_graph.cppnode-info tests had hardcoded expected publisher counts that silently assumed the implicit/rosoutpublisher every node gets upstream — which doesn't exist underRCL_MICROROS'senable_rosout=falsedefault.Also added/fixed test guards for functionality intentionally stripped under
RCL_MICROROS(remapping, rosout, type-hash, type-description service, CFT), and cleaned up a batch of pre-existingcpplint/uncrustify/lint_cmakeformatting issues.rcl_yaml_param_parserremains intentionally excluded from the build (COLCON_IGNORE), unchanged.Is this user-facing behavior change?
Yes, the
enclave/security-options fix and thedisable_loaned_messagefix are real runtime corrections, not just test updates. Previously,rcl_init()would fail whenever the RMW required a properly-populated enclave, and loaned-message capability was read from undefined memory.Did you use Generative AI?
Yes, Claude Code assisted with conflict resolution and debugging.
Additional Information