feat: externally dereference $dynamicRef - #503
Merged
Merged
Conversation
aqeelat
added a commit
to aqeelat/OpenAPIKit
that referenced
this pull request
Jul 11, 2026
…ferencing locallyDereferenced() / dereferenced(in:) now resolve $dynamicRef against the dynamic scope (outermost $dynamicAnchor wins, per JSON Schema 2020-12). Non-recursive targets are inlined; recursive or unresolvable dynamic refs throw, consistent with static $ref cycles and the Dereferenced... invariant (a DereferencedJSONSchema must not contain references). Implements the 'dynamic-scope-aware dereferencing' item from mattpolzin#359. Edits the same migration-guide section as mattpolzin#503 (external deref); reconcile on merge. Part of mattpolzin#359.
mattpolzin
reviewed
Jul 29, 2026
Delegate the .dynamicReference case of externallyDereferenced to the wrapped JSONReference's external deref -- the same path $ref uses. External $dynamicRef targets are fetched via the loader and rewritten to internal component references; internal dynamic refs are unchanged. The result stays a .dynamicReference (serializes as $dynamicRef, preserving the dynamic semantic). Part of mattpolzin#359.
mattpolzin
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #359.
Implements the "External dereferencing of
$dynamicRef" item from the #359 task list. The.dynamicReferencecase ofexternallyDereferenced(with:)previously passed through unchanged (with a TODO); it now delegates to the wrappedJSONReference's external deref — reusing the same tested path$refuses.$dynamicRef(target is an external URI): fetched via the suppliedExternalLoaderand rewritten to an internal component reference.$dynamicRef(anchor): unchanged (external deref is a no-op for internal refs, mirroring$ref)..dynamicReference(still serializes as$dynamicRef), preserving the dynamic-anchor semantic. Cross-document dynamic-scope resolution stays out of scope (tracked separately in Support$dynamicRefand$dynamicAnchor#359).Testing
SchemaLoadermock.release/7_0(which now includes feat: resolve$dynamicRefagainst the dynamic scope #504 — local dynamic-scope resolution).$dynamicRef" section alongside the existing local-resolution section from feat: resolve$dynamicRefagainst the dynamic scope #504.This PR was drafted with assistance from AI tooling. The submitter has reviewed and validated the contents prior to submission.