MLE-32228 Ship SBOM in NPM package - #1117
Merged
Merged
Conversation
rjdew-progress
requested review from
RitaChen609,
jonmille,
ngodugu-marklogic and
rjrudin
as code owners
August 28, 2026 15:47
There was a problem hiding this comment.
Pull request overview
This PR adds a Software Bill of Materials (SBOM) to the published NPM package by generating a versioned SPDX JSON filename during publish and whitelisting it for inclusion in the package tarball.
Changes:
- Include
marklogic-*.spdx.jsonin the published package via thefileswhitelist. - Add a
prepublishOnlystep intended to generate a versioned SBOM filename fromsbom.spdx.json. - Ignore generated SBOM artifacts in
.gitignore.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Whitelists the SBOM artifact for publishing and adds a publish-time generation script. |
| .gitignore | Prevents locally generated SBOM publish artifacts from being committed. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "scripts": { | ||
| "doc": "jsdoc -c jsdoc.json lib/*.js README.md", | ||
| "lint": "gulp lint", | ||
| "prepublishOnly": "cp sbom.spdx.json \"marklogic-${npm_package_version}.spdx.json\"", |
rjrudin
approved these changes
Aug 28, 2026
RitaChen609
approved these changes
Aug 28, 2026
jonmille
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.