Skip to content

Water identification fix - #460

Open
bozimmerman wants to merge 1 commit into
mangoszero:masterfrom
bozimmerman:water_id_fix
Open

Water identification fix#460
bozimmerman wants to merge 1 commit into
mangoszero:masterfrom
bozimmerman:water_id_fix

Conversation

@bozimmerman

@bozimmerman bozimmerman commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

I found a spot where the code wasn't properly reporting the water/underwater status of playerbots and traced it down to misidentifying the TYPE of liquid.


This change is Reviewable

@codacy-production

codacy-production Bot commented Jul 23, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 5 complexity · 0 duplication

Metric Results
Complexity 5
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@bozimmerman
bozimmerman marked this pull request as draft July 23, 2026 18:06
@bozimmerman

bozimmerman commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Ugh .. builds fine on my machine, but I understand now why it's not building here. Working on it.
The new solution is not a minor tweek.. still working on it.

OK, required some very minor gymnastics, but this latest seems to work. When it's through testing, I'll expose it for review.

@AppVeyorBot

Copy link
Copy Markdown

@AppVeyorBot

Copy link
Copy Markdown

@MadMaxMangos

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6f9bd65fe2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/game/vmap/VMapManager2.cpp Outdated
@MadMaxMangos
MadMaxMangos force-pushed the master branch 2 times, most recently from 0c536ae to 43a7fcc Compare July 26, 2026 18:50
@bozimmerman
bozimmerman marked this pull request as ready for review July 29, 2026 02:59
@AppVeyorBot

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants